On 22 January 2018 at 09:53, Stefan Bodewig <bode...@apache.org> wrote: > On 2018-01-21, sebb wrote: > >> On 21 January 2018 at 16:07, Stefan Bodewig <bode...@apache.org> wrote: > >>> The contract of tar archives is they contain relative path names. GNU >>> tar strips leading slashes both when creating archives and when >>> extracting archives who's entry names contain leading slashes. Sticking >>> with that contract I still believe we should remove leading slashes by >>> default - and removing the drive letters is the Windows equivalent of it >>> IMHO. That's why I suggest to keep the drive letter in the >>> preserveLeadingSlashes == true case. > >> I would expect the Windows default behaviour to generate/use relative >> names only. >> This means dropping both the drive letter *and* any leading \ or /. > > This is what happens right now. > >> Optionally, tar should be able to preserve/use absolute path names. >> But the user must specify this. > > This is what I suggested. Change the meaning of "preserveLeadingSlashes" > to "preserveAbsolutePath" and use it to keep the drive letter on > Windows. > > The current code will always strip the drive letter spec.
In that case, I agree with you. Also as a name, 'preserveLeadingSlashes' only makes sense on a unix system, and it describes the processing rather than the functionality. > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
