GitHub user oscarlvp opened a pull request:
https://github.com/apache/commons-io/pull/61
Strengthen TeeOutputStremTest.testTee with an expected result.
Tee should not just repeat what's being written to both outputs, the output
should also be the same as expected. For example, if the body of any of the
`write` methods in TeeOutputStream is removed,
then the values written are the same (nothing) and the assertions don't
fail in the test. This is solved by adding an expected value and checking both
outputs against it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oscarlvp/commons-io master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-io/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit af0cf1a22c387edce15daf8fff16bf538fca9997
Author: oscarlvp <oscarlvp@...>
Date: 2018-05-31T09:32:19Z
Strengthen TeeOutputStremTest.testTee with an expected result.
Tee should not just repeat what's being written to both outputs,
the output should also be the same as expected. For example, if
the body of any of the write methods in TeeOutputStream is removed,
then the values written are the same (nothing) and the assertions
don't fail in the test. This is solved by adding an expected value
and checking both outputs against it.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
