On 2018-08-22, Rob Tompkins wrote: >> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter <brit...@apache.org> wrote:
>> Hi, >> I don't understand this discussion. Changes in Commons Parent have broken >> the commons-compress build. So we should either roll this changes back or >> those who need the changes in commons parent should fix the commons >> compress build. > I think the problem at hand here is that we, across our projects, are > inconsistent with our usage of componentId, so naturally any changes > to the way we consume it in the parent are breaking changes. For > example: > https://github.com/apache/commons-lang/blob/master/pom.xml#L573 > <https://github.com/apache/commons-lang/blob/master/pom.xml#L573> > versus > https://github.com/apache/commons-collections/blob/master/pom.xml#L487 > <https://github.com/apache/commons-collections/blob/master/pom.xml#L487> As Gilles already said, the commons-lang version doesn't adhere to the documentation in the parent POM. Anyway https://github.com/apache/commons-parent/blob/trunk/pom.xml#L1942 is wrong for both of them as all subdirectories of https://svn.apache.org/repos/infra/websites/production/commons/content/proper/ start with "commons-" and no ${commons.componentid} does so. That's why I don't understand how site-deploy can work for commons-lang or commons-collections. I've simply overwritten the commons.scmPubUrl in Compress' POM to make it work again. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
