On Wed, 17 Oct 2018 at 17:06, Matt Sicker <[email protected]> wrote: > > Can you make a folder like "Apache Commons" and then put all the Commons > jobs there? All of them will have a space in the name because of the parent > item name.
Nice idea. "Apache Commons" will go against the existing convention. But it might be acceptable to use "Commons components". > On Wed, 17 Oct 2018 at 03:47, sebb <[email protected]> wrote: > > > On Wed, 17 Oct 2018 at 01:05, Gary Gregory <[email protected]> wrote: > > > > > > Sounds reasonable but we need unit tests that also include spaces so that > > > we do rely on the build location as a test. > > > > Ideally, but I don't think that's possible in general. > > > > For example, the IO-589 error happened because the classpath contained a > > space. > > In this case, I guess it would have been possible to use a test file > > whose name contained a space, but there may be other places where only > > the classpath affects the result. I think that would be very difficult > > to achieve without using a base path with a space in it. > > > > Besides, one does not know in advance which tests are going to fail, > > and therefore which tests need to be adjusted. > > > > > Gary > > > > > > On Tue, Oct 16, 2018, 17:39 sebb <[email protected]> wrote: > > > > > > > IO-589 was accidentally found by trying to test in a path which > > > > happened to contain a space. > > > > This revealed a bug (in test code) which did not properly convert from > > > > URL path to file system path. > > > > > > > > I think it would make sense to rename the Jenkins jobs to ensure all > > > > the tests have a space in the path. > > > > > > > > Possibly go further and try to introduce other special characters such > > > > as $&+,:;=?@. > > > > > > > > I've made a start with NET, which has built and tested OK. > > > > > > > > WDYT? > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > -- > Matt Sicker <[email protected]> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
