aremily commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r256666064
##########
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##########
@@ -135,3 +96,35 @@ JNIEXPORT jstring JNICALL
Java_org_apache_commons_crypto_OpenSslInfoNative_Nativ
{
return (*env)->NewStringUTF(env, PROJECT_NAME);
}
+
+JNIEXPORT jlong JNICALL
Java_org_apache_commons_crypto_OpenSslInfoNative_OpenSSL
+ (JNIEnv *env, jclass clazz)
+{
+ if (!load_library(env)) {
+ return 0;
+ }
+ if(OPENSSL_VERSION_NUMBER > VERSION_1_1_X){
Review comment:
I replaced it with a dynamic lookup, following the existing pattern of
dlsyming functions via a load macro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
