+1 Reports, signatures good build works properly on java 8, and has documented failure on java 10 and 11.
Few nits checkstyle, pmd, cpd. Quite happy that our test coverage is improving as well. > On Feb 15, 2019, at 11:01 AM, Gary Gregory <[email protected]> wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.5.0 was released, so I would like to release > Apache Commons DBCP 2.6.0. > > Apache Commons DBCP 2.6.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (svn > revision 32518) > > The Git tag commons-dbcp-2.6.0-RC1 commit for this RC is > 3e7fca08d3585aa7cf70045ee3ed607cbaf04baa which you can browse here: > > https://github.com/apache/commons-dbcp/releases/tag/commons-dbcp-2.6.0-RC1 > > Maven artifacts are here: > https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.6.0-RC1 > > https://repository.apache.org/content/repositories/orgapachecommons-1425/org/apache/commons/commons-dbcp2/2.6.0/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-512s > #Fri Feb 15 10:46:39 EST 2019 > commons-dbcp2-2.6.0-src-tar.gz=edf28b1a7fecaa8149a00f796e1116f72ee502ab24853c623b397ea07fc4c63408f31930e24a9abd43edbdfcd4c17b16559a5ffcba01c954f5161c96eb860f74 > commons-dbcp2-2.6.0-src-tar.gz.asc=d991126ab89f8b594da690e12cdb5ef05dde4e78f575f35284cc195349d3b438a47c7648d0e3189ff37d1cfdeac48f3d929fd0af46ad146911a25207ab36301b > commons-dbcp2-2.6.0-tests-test-jar=ee304fd225d3a850c96b88d84195d26fd11370e529b9699b554e38dcef87be1006695bf818cb44ea7cd90e5ac65db59a1e656869e711fb1cd11d95727886d265 > commons-dbcp2-2.6.0-test-sources-java-source=fe3c9367446ed44e06f2328e890517ad1818bbc6f8a53cbde8410c2d6308937f889bb164a2d76ff90837befcdccdff410a1c4de17e92a05b1a395c79b1f84325 > commons-dbcp2-2.6.0-bin-tar.gz=3231c0431ed683bd99cb5b24ad6fa18a2693e39a23f22f6d36e30e54ec3b2dd2f7320c98e345577385443d30bf9d6d857e9b768107ba353048cce3651e6f4c9e > commons-dbcp2-2.6.0-bin-tar.gz.asc=26e7f73436db583d6cdfe8037d5afeb43fdd67c0712bd915806427aa291921b39868614f16fb900a6d7266c541be3eae63bc5f152661fbe3341615a6bffa503e > commons-dbcp2-2.6.0-javadoc-javadoc=31d7af557c41adfcd6fce58282ae2b5f045f278a5f829ad5661e31c80137f9b32e3eb29a5088c542a5664de882a6de816ed5daa4ebae233fed16d2688f66b016 > commons-dbcp2-2.6.0-src-zip.asc=98434d9d165a85f4bd7f2cdaaa776204bd274dd919d22e7542ee9b98a84323236f05946e01dcd31c430b3fb028b3c8b30be733d49e4f0bc9324bd27782f3c1e3 > commons-dbcp2-2.6.0-test-sources-jar.asc=668b378078ea24407a9ccd2e76479bec54db722408276fc343f25df7b3679f84ccf2548b843a57f49a5e73e542d70f1b16306838c18b123a005e0055a5e2f5dc > commons-dbcp2-2.6.0-src-zip=955514067b4e774e53aecc906d3497f4e966b0abf76d61d2abc600957d42c5151e0c21c660ebc6d86a35ae78e41d710819ba9dbd67bc39b701004239c89c34e8 > commons-dbcp2-2.6.0-tests-jar.asc=99efeb6ae0c576389270655967484fde298b59a1da62f25e6b308e867cdc9f7ecc0a8281820a7d070776acf3d2be6f7d445bc1a7cd2270883d6a05684c8519f1 > commons-dbcp2-2.6.0-jar.asc=c88950da16bd1ed5ff6f7eb06eead26dff3fe864f5a4830537d49f61d99afc46491cba5c1af6b09815bbe5b33001f6ccaec0bf9f30d29ea25684aa81f0ae7267 > commons-dbcp2-2.6.0-sources-java-source=971ff6b43e91d4350d14ec4fbb25da5c4a3e73469fa1834b26c2cdda9b2ddf4037370a73e9b51abed61f4e59f43e0600409082ae85e88f598418249cd5d227e9 > commons-dbcp2-2.6.0-sources-jar.asc=0f12bab2270e5569ed6260f646f3bd5d830b35d517363578f842232842fa48e62c579f8ae44ef2b7dc82fadb38191c346bf1f4e512358768c23259fca42d96d8 > commons-dbcp2-2.6.0-bin-zip=d115146bea6026ed26a5944e99448427c31d89a147b85a4fcf6e24fc8c42a26d0afa5b1485a64b67243493f2cb4f183b636ff35f7576757d079d7c18502c1761 > commons-dbcp2-2.6.0-bin-zip.asc=3ac3e77075134175daaf015d98bcd259a4db8330d0985614f015f5a273c32ef2d12dd673485c73239e8f5b3ce55a7b944cfdcdff599a9b2c5e9ec793c13091cd > commons-dbcp2-2.6.0-pom.asc=b567be342c4736663f170f00abdaf399ec6020115288710aaa611ebbecfe4d1680b2c5ca48e09e0228b2b9122491e47b52b78858a1c91ac21cdd569444eca3a1 > commons-dbcp2-2.6.0-javadoc-jar.asc=ac4930c222543406378dd2a83ee58d4b39985b974dfaee5489e2af7d6a3d555be5e6d30a81ed6414235abb1c7031e9981e1164cf5807ac1d7f303421d7017cd8 > > > (no need for .asc hashes!) > > I have tested this with 'mvn clean install site' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T14:41:47-04:00) > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_202\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > and the 'mvn test -Dcommons.jacoco.version=0.8.3' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T14:41:47-04:00) > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk-11.0.2 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 2.5.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site/changes-report.html > > Site: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site > (note some *relative* links are broken and the 2.6.0 directories are > not yet created - these will be OK once the site is deployed.) > > CLIRR Report (compared to 2.5.0): > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site/clirr-report.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
