On Tue, 9 Apr 2019 at 08:54, sebb <seb...@gmail.com> wrote:
>
> On Tue, 9 Apr 2019 at 07:59, Jochen Wiedmann <jochen.wiedm...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > I have studied EMAIL-186. My impression is, that all commons jar files
> > should provide a fixed module name, rather than trusting in the choice
> > of the JDK. Thus, it seems best to handle this in parent. So, here's
> > my proposal for a change. Please, let me know, what you think of that,
> > so that I can either fix it, op proceed with committing.
>
> What exactly does 'fixed' mean in this context?
>
> If it is supposed to be tied to API compatibility, then strictly
> speaking it needs the group-id as well.
>
> If there is only supposed to be one module name regardless of API
> compatibility, then artifact-id won't do as it is not immutable.
>
> > Thanks,
> >
> > Jochen
> >
> >
> > $ git diff pom.xml
> > diff --git a/pom.xml b/pom.xml
> > index 2612dd6..54a88e4 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -570,6 +570,7 @@
> >
> > <Implementation-Build>${implementation.build}</Implementation-Build>
> >
> > <X-Compile-Source-JDK>${maven.compiler.source}</X-Compile-Source-JDK>
> >
> > <X-Compile-Target-JDK>${maven.compiler.target}</X-Compile-Target-JDK>
> > +
> > <Automatic-Module-Name>${commons.module.name}</Automatic-Module-Name>
> > </manifestEntries>
> > </archive>
> > </configuration>
> > @@ -1608,6 +1609,9 @@
> > <maven.compiler.source>1.3</maven.compiler.source>
> > <maven.compiler.target>1.3</maven.compiler.target>
> >
> > + <!-- Module name for Java 9, and beyond -->
> > + <commons.module.name>${project.artifactId}</commons.module.name>
> > +
> > <!-- compiler and surefire plugin settings for "java" profiles -->
> > <commons.compiler.fork>false</commons.compiler.fork>
> > <commons.compiler.compilerVersion />
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
Really like this change, but as a consumer of the jars generated by
this parent patch, could the default not be the artifactId, as it will
just mean 2 migrations.
As commons-lang3 has the module name org.apache.commons.lang3, not
commons-lang3 which is the artifactId, because "-" is invalid in a
real module name and they realised this when starting to support jpms.
So could the default be something like OVERRIDE_PER_RELEASED_JAR, so
it's very very clear.
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
