> On Apr 10, 2019, at 7:20 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
> 
> Hi All:
> 
> In BCEL, we log a warning to the console:
> 
> https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/classfile/Attribute.java#L240
> 
> Which you can't really do anything about since it does not tell you what
> class file it is complaining about.
> 
> 1) Should remove the logging?

Uncertain here. In the general case, I feel like we should either do nothing or 
throw an exception. But the logic feels like it warrants some explanation, so I 
don’t know

> or,
> 2) Should we improve the logging?

This should be our minimal plan, if removing it doesn’t make sense.

> or,
> 3) Do nothing?

Because you brought it up, it feels like something should be done?

> 
> Gary

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to