(please make sure to CC me on replies) On Sun, 2 Jun 2019 at 01:09, Karl Heinz Marbaise <khmarba...@gmx.de> wrote:
> Hi, > > On 01.06.19 23:51, Alex Herbert wrote: > > > > > >> On 1 Jun 2019, at 20:59, Karl Heinz Marbaise <khmarba...@gmx.de> wrote: > >> > >> Hi, > >> > >> created an appropriate branch[1] with a first implementation to check If > >> this is going into the right direction if not please let me know… > >> > > > I do not see why the private count variable is an object Long and not a > primitive long. > > > Why the explicit BigDecimalConsumer interface? Why not > Consumer<BigDecimal>? Use the JDK standard Consumer interface and you get > the default methods added for ‘free’ and do not add a redundant interface > to the codebase. > > Makes of course more sense...... > Reviewed on the commit. -- Eitan Adler
