+1 to skipping Clirr until 1.0. Gary
On Tue, Jun 4, 2019, 06:24 Bruno P. Kinoshita <ki...@apache.org> wrote: > I had a look at ways to skip just this error... but we are not maintaining > BC with sanselan-0.97, which means that we may change more in the API, and > have one or many more alpha releases. > So instead of manually adding each entry to be ignored, I thought it would > make more sense to use clirr only after 1.0 is out and we have a previous > released version to compare against. > (In practice, imaging has no official release yet, only alpha versions... > sanselan never reached 1.0, and the code changed a lot since it moved to > commons & imaging) > Bruno > > Sent from Yahoo Mail on Android > > On Tue, 4 Jun 2019 at 21:39, Alex Herbert<alex.d.herb...@gmail.com> > wrote: Why not just exclude this method using ignored differences? [1] > > That will allow you to keep clirr:check active. > > [1] > > https://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html > > > On Tue, 4 Jun 2019, 09:22 Bruno P. Kinoshita, <ki...@apache.org> wrote: > > > Hi, > > > > > > There is a user PR [1] and another PR that I created yesterday [2] > failing > > in Travis-CI due to clirr:check. > > > > > > Clirr is checking the current snapshot 1.0-alpha2-SNAPSHOT against > > 1.0-alpha1. And is failing as we have renamed a public method > (getFilename > > -> getFileName). > > > > > > I believe backward incompatible changes are OK during this alpha release > > until the API stabilizes and we can release the 1.0 release. > > > > > > So I raised a PR to remove `clirr:check` from the pom.xml default target, > > and would like to merge if there are no objections, please. > > > > > > https://github.com/apache/commons-imaging/pull/45 > > > > > > Thanks! > > Bruno > > > > [1] https://github.com/apache/commons-imaging/pull/43 > > > > [2] https://github.com/apache/commons-imaging/pull/44 > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > >