[x] +1 Release these artifacts
Build passing on JDK 8, Ubuntu LTS, Maven 3.5.2. No blockers in the site
reports.
Couldn't check the signatures. But everything else looks good to me.
Thanks!Bruno
On Saturday, 6 July 2019, 6:54:41 am NZST, Gary Gregory
<ggreg...@apache.org> wrote:
We have fixed quite a few bugs and added some enhancements since Apache
Commons Collections 4.3 was released, so I would like to release Apache
Commons Collections 4.4.
Apache Commons Collections 4.4 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1 (svn
revision 34783)
The Git tag commons-collections-4.4-RC1 commit for this RC is
cab58b3a8093a2f6b84f12783a3fb358747310f7 which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=cab58b3a8093a2f6b84f12783a3fb358747310f7
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-collections.git
--branch commons-collections-4.4-RC1 commons-collections-4.4-RC1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1446/org/apache/commons/commons-collections4/4.4/
These are the artifacts and their hashes:
#Release SHA-512s
#Fri Jul 05 14:10:15 EDT 2019
commons-collections4-4.4-bin.tar.gz=678068a958aed983926a8852b25470ab1dcce637856f85e3b3f07fae28b25da6f2326b87d123395c4f531abfc88b74f847dbcaba9a71824adab6d52ca2568395
commons-collections4-4.4-bin.zip=96b31ba67b9ebc43f04e7188961d590020179e94c28c69a91925ff13224cd807f2becef84f6b6cc42d548283873e32ffafdd863af49fd224c1ec01e6909f6a17
commons-collections4-4.4-javadoc.jar=a8436e6429a423336958ec0ece09fa96f086f22498854a04550b6b77ac5371920e6ea8ce7269c25bf27e48735944cf8c465b6f4dfe8b1503334e6b5130a43b3c
commons-collections4-4.4-sources.jar=2755718f3a8323659de3e28b56491a67e38c730c0fc5b0b675824b77d76797b2593060af8bb7ba365f42d76318e1248645f3b2d3325b7db565cd1b4ecd6a295d
commons-collections4-4.4-src.tar.gz=2110e73eda97ca52a886cb708f21d8609a83655861594f3b6eb7a15b777d42eeeefc5d3b28ffc6ecc5e4f0b3fd5407f80019c2ce006f970f55455ef33eee47ee
commons-collections4-4.4-src.zip=bf509b6578eb093eb02322a858e5124c4242b34403e93c9b7d63f487830d41f625bf9b9cb4e5a4d17c00be9e37e183c5b1529b911101af36b34f06803f49cad9
commons-collections4-4.4-test-sources.jar=22f5d3865483a06e9d6f42395ff94c4eb8d57ac43d4e170e01c1ceb078d4f9312ffaad1b78790a877fb8dc346ed19ffa1d71d28fe4a90228e410db2cd9790501
commons-collections4-4.4-test-sources.jar.asc=d192c1d58968fc4fb5b4888b03385d8965c23cae1f6fb9d08ba90cdebe6d7f1f6bd917ddcdb129d1bae5e2f1da2f3fb8d889738c3133df865658297780dfc13c
commons-collections4-4.4-tests.jar=4eafe177278509c63c466f63bce13d8ccad62e170510c92c68a3e48762055d4f4e05d2c8fe00ba9f72d455526814793fd3e3a7a3c576a668c53de42ef7b2e801
(no need for .asc hashes!)
I have tested this with 'mvn -V -Duser.name=%my_apache_id%
-Dcommons.release-plugin.version=%commons.release-plugin.version%
-Ddoclint=none -Prelease -Pjacoco -Pjapicmp -Ptest-deploy clean package
site deploy' using:
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_212\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
In addition, running 'mvn -V clean package' passed using:
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11.0.3
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 12.0.1, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-12.0.1
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 13-ea, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-13
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
openjdk version "13-ea" 2019-09-17
OpenJDK Runtime Environment (build 13-ea+25)
OpenJDK 64-Bit Server VM (build 13-ea+25, mixed mode, sharing)
OpenJDK 14-EA fails:
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 14-ea, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-14
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
openjdk version "14-ea" 2020-03-17
OpenJDK Runtime Environment (build 14-ea+1-1)
OpenJDK 64-Bit Server VM (build 14-ea+1-1, mixed mode, sharing)
With many:
Caused by: java.lang.IllegalArgumentException: Unsupported class file major
version 58
at
org.jacoco.agent.rt.internal_035b120.asm.ClassReader.<init>(ClassReader.java:195)
at
org.jacoco.agent.rt.internal_035b120.asm.ClassReader.<init>(ClassReader.java:176)
at
org.jacoco.agent.rt.internal_035b120.asm.ClassReader.<init>(ClassReader.java:162)
at
org.jacoco.agent.rt.internal_035b120.core.internal.instr.InstrSupport.classReaderFor(InstrSupport.java:279)
at
org.jacoco.agent.rt.internal_035b120.core.instr.Instrumenter.instrument(Instrumenter.java:74)
at
org.jacoco.agent.rt.internal_035b120.core.instr.Instrumenter.instrument(Instrumenter.java:106)
Details of changes since 4.3 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/site/index.html
(note some *relative* links are broken and the 4.4 directories are not
yet created - these will be OK once the site is deployed.)
CLIRR Report (compared to 4.3):
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/site/clirr-report.html
JApiCmp Report (compared to 4.3):
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/site/japicmp.html
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/collections/4.4-RC1/site/index.html/rat-report.html
Note that the following binary test fixtures are reported in the above
report but running 'mvn apache-rat:check' passes, indicating a false
positive since 'src/test/resources/data/test/*' is excluded in the POM:
- src/test/resources/data/test/NullComparator.version4.obj1
- src/test/resources/data/test/NullComparator.version4.obj2
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-collections.git
--branch commons-collections-4.4-RC1 commons-collections-4.4-RC1
cd commons-collections-4.4-RC1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you
then must check.
mvn apache-rat:check
3) Check binary compatibility
Older components still use Apache Clirr:
This step is not required if the site includes a Clirr report page which
you then must check.
mvn clirr:check
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which
you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of
packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
-the end-
