I was advised to check with the dev mailing list if anyone has a problem with the suggested fix. It seems no one does have a problem with the fixes suggested so I'll go forward and create a PR that returns an empty array for an array of all NaNs.
On Thu, Aug 15, 2019 at 11:25 AM akash srivastava <akashsp...@gmail.com> wrote: > Here is the link for the related bug: > https://issues.apache.org/jira/browse/MATH-1495 > > I have suggested two possible fixes when NaturalRanking#rank() is called > on an array of all NaNs: > 1) throwing an IllegalArgumentException > 2) Returning an empty array > > I want to create a pull request regarding it, which fix do you suggest I > should go for? >
