I made a quick pass at changing getHasher() to iterator(). I think we can get rid of HasherBloomFilter as its purpose was really to create a Bloom filter for temporary usage and it doesn't seem to be required if we have a hasher that can be created from a Shape and a function that creates an Iterator.
On Sun, Mar 15, 2020 at 6:08 PM Alex Herbert <alex.d.herb...@gmail.com> wrote: > On Sun, 15 Mar 2020, 17:27 Claude Warren, <cla...@xenei.com> wrote: > > > We have spoken elsewhere about removing getHasher() and adding iterator() > > In addition should we add forEachBit( IntConsumer )?I > > > I was thinking the same. So we provide an iterator allowing failfast on the > first index that fails a criteria, e.g. for contains, and a foreach > allowing efficient receipt of all indexes. > > The only thing missing is whether we add a spliterator which has in its API > the ability to specify DISTINCT and the exact size of the number of > indexes. The spliterator can be a default method using the iterator to > create it. An implementation can provide one if it wants. > > > > > > > -- > > I like: Like Like - The likeliest place on the web > > <http://like-like.xenei.com> > > LinkedIn: http://www.linkedin.com/in/claudewarren > > > -- I like: Like Like - The likeliest place on the web <http://like-like.xenei.com> LinkedIn: http://www.linkedin.com/in/claudewarren
