On Tue, May 26, 2020 at 9:00 AM Xeno Amess <xenoam...@gmail.com> wrote:
> https://github.com/apache/commons-jcs/pull/11/files > https://github.com/apache/commons-validator/pull/23/files These two are merged. > > https://github.com/apache/maven-enforcer/pull/68/files I can't do anything about that one. Gary > > > > Gary Gregory <garydgreg...@gmail.com> 于2020年5月26日周二 下午8:51写道： > > > Note that the template > > > > > 'commons-build-plugin/src/main/resources/commons-xdoc-templates/contributing-md-template.md' > > is correct. > > > > Gary > > > > On Tue, May 26, 2020 at 8:48 AM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > I merged a bunch of PRs but I might have missed some in this typo area. > > > Please feel free to ping the list if we've missed some. > > > > > > TY! > > > > > > Gary > > > > > > On Mon, May 25, 2020 at 1:36 PM Xeno Amess <xenoam...@gmail.com> > wrote: > > > > > >> Ah, I go and see quite some of the repos have already fixed this > typo... > > >> So I will try to fix this typo in other repos. > > >> thx. > > >> > > >> Gary Gregory <garydgreg...@gmail.com> 于2020年5月26日周二 上午12:59写道： > > >> > > >> > Always worth fixing IMO :-) > > >> > > > >> > On Mon, May 25, 2020, 12:15 Xeno Amess <xenoam...@gmail.com> wrote: > > >> > > > >> > > in every CONTRIBUTING.md > > >> > > < > https://github.com/apache/commons-lang/blob/master/CONTRIBUTING.md > > > > > >> > (for > > >> > > example lang3 but actually almost every repo) > > >> > > > > >> > > ... > > >> > > If you're planning to implement a new feature it makes sense to > > >> discuss > > >> > > *you're* changes on the [dev list] ... > > >> > > > > >> > > should be > > >> > > > > >> > > ... > > >> > > If you're planning to implement a new feature it makes sense to > > >> discuss > > >> > > *your* changes on the [dev list] ... > > >> > > > > >> > > So, does it worth to fix it? or we just try to ignore it? > > >> > > > > >> > > > >> > > > > > >
