>- The alpha1 release notes are not there, they jump from alpha2 to 0.97

I almost gave up sending the vote this weekend after spending some minutes 
trying to understand why that was happening. Then I realized it was generated 
using a template in the [imaging] project.

The template from parent contains only the current change log. The site 
contains the complete change log.

However, the Sanselan change log is not in changes.xml. I think that's why it 
was included in the template of the project.

So I added an extra paragraph below the paragraph that alerts users that the 
complete changelog is in the website. In my paragraph I try to explain that the 
0.97 changes are the for history, from when the project was Sanselan.

Maybe we should remove them and leave only the alpha changes?

>- There is no link to the download page, which you must have if you use the
RNs as your source for the announcement email.

Funny, the download page was the first thing I generated in the project, and 
then followed the remaining instructions in the release-prepare page. Will pay 
attention if that's included when performing the release (or if I have to 
re-roll this vote thread).

>- Sentences should end in a period: First and third sentences.

Roger that. Will fix on master. Next release should have the sentences properly 
ended with a period. Or if I have to create an RC2 thread, will merge it into 
the release branch.


Thanks Gary!
Bruno



On Monday, 3 August 2020, 3:30:56 am NZST, Gary Gregory 
<garydgreg...@gmail.com> wrote: 





+1

Reviewing the git tag.

Release notes need tweaks:

- The alpha1 release notes are not there, they jump from alpha2 to 0.97
- There is no link to the download page, which you must have if you use the
RNs as your source for the announcement email.
- Sentences should end in a period: First and third sentences.

Reports OK.

Building OK running:

mvn -V clean install site -P jacoco
(no need for JapiCmp)

On the following platforms:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *1.8.0_262*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *11.0.8*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *14.0.2*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary

On Sat, Aug 1, 2020 at 7:54 PM Bruno P. Kinoshita <ki...@apache.org> wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Imaging 1.0-alpha1 was released, so I would like to
> release Apache Commons Imaging 1.0-alpha2.
>
> Apache Commons Imaging 1.0-alpha2 RC1 is available for review here:
>    https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha2-RC1
> (svn revision 40812)
>
> The Git tag commons-imaging-1.0-alpha2-RC1 commit for this RC is
> 102a89d377dcedeb72e1033fae87fd82c4d517bc which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-imaging.git;a=commit;h=102a89d377dcedeb72e1033fae87fd82c4d517bc
> You may checkout this tag using:
>    git clone https://gitbox.apache.org/repos/asf/commons-imaging.git
> --branch commons-imaging-1.0-alpha2-RC1 commons-imaging-1.0-alpha2-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-imaging/1.0-alpha2/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Aug 02 11:32:17 NZST 2020
>
> commons-imaging-1.0-alpha2-bin.tar.gz=0d0b8d8b74e137b122fc770bcf0a9654cda3971496a0cb17442c8355f7315cb2dee6c5b7a2377b44d070cff6097102e2ca1fc00d05dee307a4b97f302ab73565
>
> commons-imaging-1.0-alpha2-bin.tar.gz.asc=69871cf2c566385dcde11e6574e198e7eef78744a6fd0b971c2a283a8e7db98355880e4fe0280f053f105f28b67e9cb2ea7ccf6b12edb3b9fa57764e476a2925
>
> commons-imaging-1.0-alpha2-bin.zip=8254473f3ac5783c0f33736588e1c627ce747a1b5726342aaa8fa3a700340685eac45ff50937d52c14e3b10b72b3576da7e897e4c9e0b4a82501b007dee213aa
>
> commons-imaging-1.0-alpha2-bin.zip.asc=22cb6a9e16f1b7bf3e201e5b06950c7264e549d27ac6e4f493dd9473ee3577fcec2554966a087997ea6814165347996f7e5f1f758ad54a90fa914589dcbed08f
>
> commons-imaging-1.0-alpha2-javadoc.jar=3bfb352c77c497edacbd1c489b3cfee2a39ec364dfe9458099157bf7c1d96a3e40460e8316280ff803ba7c0b0b74fdbf1fae7c335f216f1e6259eb9e8f36485e
>
> commons-imaging-1.0-alpha2-javadoc.jar.asc=38a503317942bd4bc212881bff74803efb336cb1c09a0073eaa030f95bc6c6ff9b1edace02c504fd90f73c4d4d120d44b83871af0fe908613d1220a41b7ff4df
>
> commons-imaging-1.0-alpha2-sources.jar=4ae7091829e151f2facc5a6057e774206911bd2a3acabd12fe85cdca7bb3fbef39ac9f7ef23d6cafab611ee276f6acb9511a8e689a243d34d658064c2ad4d89c
>
> commons-imaging-1.0-alpha2-sources.jar.asc=cfec5e6037be477c1763a79e40eb69b3e748bafc2dac70635ece2d278a2c068523d9729cd6dcb86fb72a45a5993945ca1e7fad77dab34c11fd07f0d359de6965
>
> commons-imaging-1.0-alpha2-src.tar.gz=f2479e0dc726a8d1193f4eef6289efe493cfbbe257054b5a13e929f5785f7a2c9c937e3f379e0f0066c591d18be27d12f1e5157e789eebab78fba489cc81e688
>
> commons-imaging-1.0-alpha2-src.tar.gz.asc=f77fb44457ef47ea0fae224020f93060eb2fa667b3404b0e650bf87c23d2c53d4a8bdbf6f801f0b807754b6a03755efef60feef608d1daea31b5c42f545141b0
>
> commons-imaging-1.0-alpha2-src.zip=bea44ec53a55e5bf564b2d98d4f4fb72818999eb0db9c842ddae928e6da13fc7bf125d7c33fc37b907fe699de1b4202b01d1658cc97bc99b7a18bcd245a94757
>
> commons-imaging-1.0-alpha2-src.zip.asc=16066eb12ce96a3f02735db016f4cebb0223d286c4a4e32f9e2fc227c84a6e3440e72b89299bd340f158d8a71e23adba2803a6892fad1c20a82893e27356793e
>
> commons-imaging-1.0-alpha2-test-sources.jar=e6e6c5fbe20336486df3ebb98d11d146610b34838097552e145122e398981d3ff87527113d21aafaf27b1a7b471df92520c69254c6a28e0c7e92898e82005f77
>
> commons-imaging-1.0-alpha2-test-sources.jar.asc=feb1aa0d92fc50727eb7baf31c3d4fe111cb8724f9aea4b68cf6745384e0a7a69bd6cb93df38561ebc53d2b96a2a8ceb36f5c602a46247daa4fa7bf378f8393c
>
> commons-imaging-1.0-alpha2-tests.jar=10cbdf3552226fdd380b7ef5ba457b2e0a7aff07f07a2e46b056a78a80d810797f578adba7e80832c389888f69ff8bdb38abdd906fafb6c4eedef5792cf68c5c
>
> commons-imaging-1.0-alpha2-tests.jar.asc=3c52ffdb8c8f24971f5b57bdc9b3ad218f4728ce35e7404d5277e65c145b147683ccecc970282c9c972aa71f65d57872e48aec10bd111ceb2e493afc234b2c5f
>
> commons-imaging-1.0-alpha2.jar.asc=dc97309e586e13981007ad2c7805155f7b84164fced8067f7fc10358183e3ffe65f79d6e0ae34cc4192e82b18e913bea119fe3ec36dce89fdbb7b302d24fb703
>
> commons-imaging-1.0-alpha2.pom.asc=48f772ab74c42fcd5c30bdd8e43380cf96780f15c11cebad5fc6ada808001735d316374470125b4a34e49e67a2b21d1698ab32af10b8fdc8224ea50790fb009d
>
>
> (no need for .asc hashes!)
>
> I have tested this with 'mvn clean install site' using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-18T06:33:14+12:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_252, vendor: Private Build, runtime:
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-112-generic", arch: "amd64", family:
> "unix"
>
> Details of changes since 1.0-alpha1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha2-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha2-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha2-RC1/site/index.html
>    (note some *relative* links are broken and the 1.0-alpha2 directories
> are not yet created - these will be OK once the site is deployed.)
>
> CLIRR and JApiCmp are not being used right now, as we haven't maintained
> backward compatibility with
> Sanselan 0.97, nor with other alpha releases. We will enable them for 1.0.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha2-RC1/site/rat-report.html
>
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
>
> Thank you,
>
> Bruno P. Kinoshita,
> Release Manager (using key 33C6E01240C5468C2B7A556954E2764B48A42DF0)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-imaging.git
> --branch commons-imaging-1.0-alpha2-RC1 commons-imaging-1.0-alpha2-RC1
> cd commons-imaging-1.0-alpha2-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org

>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to