> On Aug 6, 2020, at 10:33 AM, Matt Sicker <[email protected]> wrote:
> 
> Now I hope we don't have unit tests depending on non-static state for
> its random number generator! ;)

We actually do have a considerable number of those in our projects where we use 
probabilistic epsilons on the output. See commons-rng. Note, Gilles is quite 
good at writing such tests.

-Rob

> I'd expect a crypto library's test
> suites to include several hard-coded known-good and known-bad
> ciphertexts with static keys/IVs similar to the test cases presented
> in their RFCs (especially since said tests are typically small enough
> to copy/paste the binary data fairly easily).
> 
> On Thu, 6 Aug 2020 at 08:19, Gary Gregory <[email protected]> wrote:
>> 
>> On Thu, Aug 6, 2020 at 8:31 AM Alex Remily <[email protected]> wrote:
>> 
>>> No problem.  I'll do it when I get home tonight.
>>> 
>> 
>> Thanks Alex!
>> 
>> Gary
>> 
>> 
>>> 
>>> On Thu, Aug 6, 2020, 8:25 AM Gary Gregory <[email protected]> wrote:
>>> 
>>>> Hi Alex,
>>>> 
>>>> Would you mind creating that ticket with that info?
>>>> 
>>>> Thank you,
>>>> Gary
>>>> 
>>>> On Thu, Aug 6, 2020, 08:10 Alex Remily <[email protected]> wrote:
>>>> 
>>>>> That is an intermittent issue that I haven't been able to reliably
>>>>> reproduce.  As I recall, the test that's failing is supposed to fail,
>>> but
>>>>> in a different way.  I think it's supposed to fail because of a short
>>>>> buffer but occasionally fails because of an internal error, and when
>>> that
>>>>> happens this test fails.  I don't know when it was introduced.  We
>>> should
>>>>> probably document it in jira and or realese notes.
>>>>> 
>>>>> On Wed, Aug 5, 2020, 10:53 PM Gary Gregory <[email protected]>
>>>> wrote:
>>>>> 
>>>>>> Hi All:
>>>>>> 
>>>>>> I am seeing what may be a random AEADBadTagException in
>>> GcmCipherTest?
>>>>>> 
>>>>>> For example:
>>>>>> 
>>>>>> [ERROR]
>>>>> testGcmTamperedData(org.apache.commons.crypto.cipher.GcmCipherTest)
>>>>>> Time elapsed: 0.015 s  <<< ERROR!
>>>>>> 881java.lang.Exception: Unexpected exception,
>>>>>> expected<javax.crypto.AEADBadTagException> but
>>>>>> was<java.lang.InternalError>
>>>>>> 882     at
>>>>>> 
>>>>> 
>>>> 
>>> org.apache.commons.crypto.cipher.GcmCipherTest.testGcmTamperedData(GcmCipherTest.java:224)
>>>>>> 883
>>>>>> 884
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Any thoughts?
>>>>>> 
>>>>>> The above is from
>>>>>> https://travis-ci.org/github/apache/commons-crypto/jobs/715348986
>>>>>> 
>>>>>> Gary
>>>>>> 
>>>>> 
>>>> 
>>> 
> 
> 
> 
> -- 
> Matt Sicker <[email protected]>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to