Oh I see why it will fail. It read the source codes in main folder when running test... However I did not clone the main folder, so it can read nothing.
Well it is not illegal but, is it necessary...? I think it weird, and maybe it is better to change those tests to use test-resources to do such things... Xeno Amess <xenoam...@gmail.com> 于2020年9月6日周日 下午9:36写道： > https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041 > see this > > Gary Gregory <garydgreg...@gmail.com> 于2020年9月6日周日 下午9:33写道： > >> On Sun, Sep 6, 2020 at 5:39 AM Xeno Amess <xenoam...@gmail.com> wrote: >> >> > Hi. >> > Smoke test seems failed. >> > https://github.com/XenoAmess/smoke-test-commons-io >> > could some guy run this locally and see why it be wrong? >> > >> >> I'm not sure what you are asking, a brief glance at >> https://github.com/XenoAmess/smoke-test-commons-io/actions shows green >> builds. >> >> I am respining another RC for what Rob found. >> >> Gary >> >> >> > >> > the plugin's source is at >> > https://github.com/XenoAmess/add-from-repo-maven-plugin , if anything I >> > wrote uncorrect, please tell me. >> > >> > Bruno P. Kinoshita <ki...@apache.org> 于2020年9月6日周日 下午3:01写道： >> > >> > > [x] +1 Release these artifacts >> > > >> > > Building from tag, with `mvn clean test install` working fine on: >> > > >> > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> > > 2018-06-18T06:33:14+12:00) >> > > Maven home: /opt/apache-maven-3.5.4 >> > > Java version: 1.8.0_265, vendor: Private Build, runtime: >> > > /usr/lib/jvm/java-8-openjdk-amd64/jre >> > > Default locale: en_NZ, platform encoding: UTF-8 >> > > OS name: "linux", version: "4.15.0-115-generic", arch: "amd64", >> family: >> > > "unix" >> > > >> > > >> > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> > > 2018-06-18T06:33:14+12:00) >> > > Maven home: /opt/apache-maven-3.5.4 >> > > Java version: 11.0.2, vendor: Oracle Corporation, runtime: >> > > /home/kinow/Development/java/jdk-11.0.2 >> > > Default locale: en_NZ, platform encoding: UTF-8 >> > > OS name: "linux", version: "4.15.0-115-generic", arch: "amd64", >> family: >> > > "unix" >> > > >> > > >> > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> > > 2018-06-18T06:33:14+12:00) >> > > Maven home: /opt/apache-maven-3.5.4 >> > > Java version: 14.0.2, vendor: Oracle Corporation, runtime: >> > > /home/kinow/Development/java/jdk-14.0.2 >> > > Default locale: en_NZ, platform encoding: UTF-8 >> > > OS name: "linux", version: "4.15.0-115-generic", arch: "amd64", >> family: >> > > "unix" >> > > >> > > >> > > Inspecting some dist area files, the commons-io-2.8.0-bin.zip has a >> > > RELEASE-NOTES.txt that fails to open on Linux as UTF-8. Mousepad asks >> for >> > > another >> > > encoding. Choosing the Windows encoding it correctly loads the release >> > > notes file. Not a blocker I think, but don't remember seeing it in >> other >> > > releases >> > > or components. >> > > >> > > Checked signatures of dist/maven files, all good. >> > > >> > > Thanks! >> > > Bruno >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > On Sunday, 6 September 2020, 2:56:06 pm NZST, Gary Gregory < >> > > ggreg...@apache.org> wrote: >> > > >> > > >> > > >> > > >> > > >> > > We have fixed a few bugs and added some enhancements since Apache >> Commons >> > > IO 2.7 was released, so I would like to release Apache Commons IO >> 2.8.0. >> > > >> > > Apache Commons IO 2.8.0 RC1 is available for review here: >> > > https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1 (svn >> > > revision 41326) >> > > >> > > The Git tag commons-io-2.8.0-RC1 commit for this RC is >> > > 2e6f1e306edd81f3d0c7d5d36f4e1de84710bd08 which you can browse here: >> > > >> > > >> > > >> > >> https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=2e6f1e306edd81f3d0c7d5d36f4e1de84710bd08 >> > > You may checkout this tag using: >> > > git clone https://gitbox.apache.org/repos/asf/commons-io.git >> > --branch >> > > commons-io-2.8.0-RC1 commons-io-2.8.0-RC1 >> > > >> > > Maven artifacts are here: >> > > >> > > >> > > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1526/commons-io/commons-io/2.8.0/ >> > > >> > > These are the artifacts and their hashes: >> > > >> > > #Release SHA-512s >> > > #Sat Sep 05 22:44:34 EDT 2020 >> > > >> > > >> > >> commons-io-2.8.0-bin.tar.gz=97187bd60827beed649736044ce0939cc6813451125319f352c6fa6c7848b31917d5f74bbc7ec29e516c7973b9c146eec654983ab562179d864b7f793c324200 >> > > >> > > >> > >> commons-io-2.8.0-bin.zip=e49874f84a05ea86e7b5d543f62557b61b5da197e9e5e9c7dea42a8237cef92116a06a537af97daf8bba4c7488a5754a58542e854836dd326e1488cd2eef19ce >> > > >> > > >> > >> commons-io-2.8.0-javadoc.jar=f7aa9e8c8322ce5d71b548bc9d40522c9609d2e080adcaf93bbcc0c6ce73d4290d9f43cacaff2e7c23f36eee42b5f6dfb79575d132743329dcd601a3c406310a >> > > >> > > >> > >> commons-io-2.8.0-sources.jar=b43e06cb68525d2d9530944319835c3e5dea19201739d8d1609cac57b7afdabbd6550efdc0be69af55567f7d003c73d4a980cbca53fbbbe3824aad19104c0fd4 >> > > >> > > >> > >> commons-io-2.8.0-src.tar.gz=60880d2ba6c0c570a0beeb355821c297eb6a543385cb651409cc2df83249c83e0994865a795574c3589e0fde95da6a77b6aa164ea5fee684093fbf65fd0a8ead >> > > >> > > >> > >> commons-io-2.8.0-src.zip=9cadd60dbdae88aa40bd3a0d8eb6130ae78c75d5929446a2fb7e70e0bc197bbaf238714d8e8b06352db234b03f390bbc5a77aefe78ee20c6d1351af1bdc3d98f >> > > >> > > >> > >> commons-io-2.8.0-test-sources.jar=086cc1d71672e7ac4239f6690fb3f6f7fb97031facc7f155e785c5253f3a4753af8ab9edda91ed8540aa11d26a9d718fc412ab345b7e64a6adb48276ec25cfb8 >> > > >> > > >> > >> commons-io-2.8.0-tests.jar=fb61e4625ffb3608aa0ac35d5b7f089d21700a242c19533f8166016a59803fe26089836558f3ea5f202739348d19b627a00b0937d678ec203d4dc1b241dd7e54 >> > > >> > > >> > >> commons-io-2.8.0.jar.asc=16235d9e4b9c66aab8bc462f61170e7b444147f0f8ed1fa82f0b106be1a58aa752616581527d65cf72f482ff71cc6ca1648385a6712af372bf9230748623471c >> > > >> > > I have tested this with: >> > > >> > > mvn -V -Duser.name=$my_apache_id >> > > -Dcommons_release_plugin_version=$commons_release_plugin_version >> > -Prelease >> > > -Ptest-deploy -P jacoco -P japicmp clean package site deploy >> > > >> > > using: >> > > >> > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >> > > Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec >> > > Java version: 1.8.0_265, vendor: AdoptOpenJDK, runtime: >> > > /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre >> > > Default locale: en_US, platform encoding: UTF-8 >> > > OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac" >> > > >> > > Details of changes since 2.7 are in the release notes: >> > > >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1/RELEASE-NOTES.txt >> > > >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1/site/changes-report.html >> > > >> > > Site: >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1/site/index.html >> > > (note some *relative* links are broken and the 2.8.0 directories >> are >> > > not yet created - these will be OK once the site is deployed.) >> > > >> > > *** JApiCmp Report (compared to 2.7): >> > > >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1/site/japicmp.html >> > > >> > > RAT Report: >> > > >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1/site/rat-report.html >> > > >> > > KEYS: >> > > https://www.apache.org/dist/commons/KEYS >> > > >> > > Please review the release candidate and vote. >> > > This vote will close no sooner than 72 hours from now. >> > > >> > > [ ] +1 Release these artifacts >> > > [ ] +0 OK, but... >> > > [ ] -0 OK, but really should fix... >> > > [ ] -1 I oppose this release because... >> > > >> > > Thank you, >> > > >> > > Gary Gregory, >> > > Release Manager (using key 86fdc7e2a11262cb) >> > > >> > > For following is intended as a helper and refresher for reviewers. >> > > >> > > Validating a release candidate >> > > ============================== >> > > >> > > These guidelines are NOT complete. >> > > >> > > Requirements: Git, Java, Maven. >> > > >> > > You can validate a release from a release candidate (RC) tag as >> follows. >> > > >> > > 1) Clone and checkout the RC tag >> > > >> > > git clone https://gitbox.apache.org/repos/asf/commons-io.git --branch >> > > commons-io-2.8.0-RC1 commons-io-2.8.0-RC1 >> > > cd commons-io-2.8.0-RC1 >> > > >> > > 2) Check Apache licenses >> > > >> > > This step is not required if the site includes a RAT report page which >> > you >> > > then must check. >> > > >> > > mvn apache-rat:check >> > > >> > > 3) Check binary compatibility >> > > >> > > Older components still use Apache Clirr: >> > > >> > > This step is not required if the site includes a Clirr report page >> which >> > > you then must check. >> > > >> > > mvn clirr:check >> > > >> > > Newer components use JApiCmp with the japicmp Maven Profile: >> > > >> > > This step is not required if the site includes a JApiCmp report page >> > which >> > > you then must check. >> > > >> > > mvn install -DskipTests -P japicmp japicmp:cmp >> > > >> > > 4) Build the package >> > > >> > > mvn -V clean package >> > > >> > > You can record the Maven and Java version produced by -V in your VOTE >> > > reply. >> > > To gather OS information from a command line: >> > > Windows: ver >> > > Linux: uname -a >> > > >> > > 5) Build the site for a single module project >> > > >> > > Note: Some plugins require the components to be installed instead of >> > > packaged. >> > > >> > > mvn site >> > > Check the site reports in: >> > > - Windows: target\site\index.html >> > > - Linux: target/site/index.html >> > > >> > > 6) Build the site for a multi-module project >> > > >> > > mvn site >> > > mvn site:stage >> > > Check the site reports in: >> > > - Windows: target\site\index.html >> > > - Linux: target/site/index.html >> > > >> > > -the end- >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > > For additional commands, e-mail: dev-h...@commons.apache.org >> > > >> > > >> > >> >
