This VOTE passes with the following +1 binding votes: - Bruno P. Kinoshita - Rob Tompkins - Gary Gregory
Gary On Sat, Oct 3, 2020 at 1:01 AM Gary Gregory <garydgreg...@gmail.com> wrote: > My +1 > > Gary > > > On Thu, Oct 1, 2020 at 1:32 PM Rob Tompkins <chtom...@gmail.com> wrote: > >> +1 >> >> Builds well with java 8 and java 11 >> >> Reports look good. >> >> Ran this script for signature validation: >> https://github.com/chtompki/notes/blob/master/commons-release-validation/mover-downloader-and-validator.sh >> >> Note. I think we can likely templatize this script for future release >> valication. >> >> -Rob >> >> > On Sep 30, 2020, at 12:45 AM, Gary Gregory <ggreg...@apache.org> wrote: >> > >> > *[The difference between RC1 and RC2 is that pom.xml fil**le's* *version >> > has been fixed to be 3.7.1 instead of 3.7.1-SNAPSHOT.]* >> > >> > We have fixed one regression bug since Apache Commons Net 3.7 was >> released, >> > so I would like to release Apache Commons Net 3.7.1. >> > >> > Apache Commons Net 3.7.1 RC2 is available for review here: >> > https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2 (svn >> > revision 41637) >> > >> > The Git tag commons-net-3.7.1-RC2 commit for this RC is >> > 2a64bdb3790ac526d494b187063e524942e82182 which you can browse here: >> > >> > >> https://gitbox.apache.org/repos/asf?p=commons-net.git;a=commit;h=2a64bdb3790ac526d494b187063e524942e82182 >> > You may checkout this tag using: >> > git clone https://gitbox.apache.org/repos/asf/commons-net.git >> --branch >> > commons-net-3.7.1-RC2 commons-net-3.7.1-RC2 >> > >> > Maven artifacts are here: >> > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1531/commons-net/commons-net/3.7.1/ >> > >> > These are the artifacts and their hashes: >> > >> > #Release SHA-512s >> > #Wed Sep 30 00:07:45 EDT 2020 >> > >> commons-net-3.7.1-bin.tar.gz=924533fa16dfc6d29f093c154a0111be82bcc2a6a95eda63d2f33938206269ad0df4471136237aadce92da3517d6c8e4a05fabc3a6873814d66c9ace78366c97 >> > >> commons-net-3.7.1-bin.zip=761d910baec05857d6fc1d1865d2384ef3539e71234bc8fcf5c8ce895191317625cde4af4c1f7fe4c398e52d786e351b51e69d0584bb5fa15daea736d850da6a >> > >> commons-net-3.7.1-javadoc.jar=916bd4e94d1efb65a497b851f8cba68c281bf84c503fb6e8dcb13e2ce9ea463d9018df1177e659b5a3f3ec9130decd9729c5edfabe7fd368fb41b0ec69a68343 >> > >> commons-net-3.7.1-sources.jar=f8d15453afb81d34b60086e9cfc151ff6ebfb01d0282d151641b573d30c56e93cdded0272cea2ce223f5fd99afbd6b084b03b5510c36d3e7c539002977eedb3d >> > >> commons-net-3.7.1-src.tar.gz=e0b522ffdd3a38787173c2ebf1b6f09406fd3a45fc048673c60547d5a4a32057cad8f64411d84ccd465fb9c030debca36e11c3716e5ef2e2dab24b207f3e5479 >> > >> commons-net-3.7.1-src.zip=b63c255ef14dd7760c3c0c62672cb61f090e2bcb17277543bc1f2cbea98ea0461673df65c66e01397b7a3087eb5641e709c06b384645900fe670dce6e5029373 >> > >> commons-net-3.7.1-test-sources.jar=bff463ad56fe001fc9ae0c9b7882e423b96a35235bb02004a389f2f57c15e2c16b75c31f94bf8e1c87c027e47f40380cee6cbe718f8d57225cc282454f9e5d41 >> > >> commons-net-3.7.1-tests.jar=8a1d7269b8e93e4c4dcc3077e316a1e32728c0f02ba89b91862864d68304ac35c7cf0481e6f14e6015e761009518634c494456145ec78f1fedecea5df29ad94a >> > >> commons-net-examples-3.7.1.jar=458ab2fdc3209041322a6f65ba52928f73a19c25796c9c8e4b721660ef29f533abfb1b242ecf9d1d3c14f2e7054979526c9e62c7da8d7e4c05ffffd94248d78b >> > >> commons-net-ftp-3.7.1.jar=f45c9d9d063f41849601cd20b7a9b93ef4151d37694951fa146259b44e47881fdeb28ee843a5dea5a5bd37c90f902abc747933e2c90c4a6e0f44f1983b8d125f >> > >> > I have tested this with >> > >> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site >> > deploy >> > >> > using: >> > >> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >> > Maven home: C:\Java\apache-maven-3.6.3\bin\.. >> > Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program >> > Files\Java\jdk1.8.0_251\jre >> > Default locale: en_US, platform encoding: Cp1252 >> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> > >> > Details of changes since 3.7 are in the release notes: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/RELEASE-NOTES.txt >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/site/changes-report.html >> > >> > Site: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/site/index.html >> > (note some *relative* links are broken and the 3.7.1 directories are >> > not yet created - these will be OK once the site is deployed.) >> > >> > CLIRR Report (compared to 3.7): >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/site/clirr-report.html >> > >> > JApiCmp Report (compared to 3.7): >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/site/japicmp.html >> > >> > RAT Report: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.1-RC2/site/rat-report.html >> > >> > KEYS: >> > https://www.apache.org/dist/commons/KEYS >> > >> > Please review the release candidate and vote. >> > This vote will close no sooner than 72 hours from now. >> > >> > [ ] +1 Release these artifacts >> > [ ] +0 OK, but... >> > [ ] -0 OK, but really should fix... >> > [ ] -1 I oppose this release because... >> > >> > Thank you, >> > >> > Gary Gregory, >> > Release Manager (using key 86fdc7e2a11262cb) >> > >> > For following is intended as a helper and refresher for reviewers. >> > >> > Validating a release candidate >> > ============================== >> > >> > These guidelines are NOT complete. >> > >> > Requirements: Git, Java, Maven. >> > >> > You can validate a release from a release candidate (RC) tag as follows. >> > >> > 1) Clone and checkout the RC tag >> > >> > git clone https://gitbox.apache.org/repos/asf/commons-net.git --branch >> > commons-net-3.7.1-RC2 commons-net-3.7.1-RC2 >> > cd commons-net-3.7.1-RC2 >> > >> > 2) Check Apache licenses >> > >> > This step is not required if the site includes a RAT report page which >> you >> > then must check. >> > >> > mvn apache-rat:check >> > >> > 3) Check binary compatibility >> > >> > Older components still use Apache Clirr: >> > >> > This step is not required if the site includes a Clirr report page which >> > you then must check. >> > >> > mvn clirr:check >> > >> > Newer components use JApiCmp with the japicmp Maven Profile: >> > >> > This step is not required if the site includes a JApiCmp report page >> which >> > you then must check. >> > >> > mvn install -DskipTests -P japicmp japicmp:cmp >> > >> > 4) Build the package >> > >> > mvn -V clean package >> > >> > You can record the Maven and Java version produced by -V in your VOTE >> reply. >> > To gather OS information from a command line: >> > Windows: ver >> > Linux: uname -a >> > >> > 5) Build the site for a single module project >> > >> > Note: Some plugins require the components to be installed instead of >> > packaged. >> > >> > mvn site >> > Check the site reports in: >> > - Windows: target\site\index.html >> > - Linux: target/site/index.html >> > >> > -the end- >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
