Hi Bruno, The files in BUILDING.txt are not up to date with what I do to test an RC build, so I'll update those with:
mvn -V -Ptest-deploy -Prelease clean install -DskipTests mvn -V -Ptest-deploy -Prelease -P japicmp -P jacoco site mvn -V -Ptest-deploy -Prelease deploy mvn -V -Ptest-deploy -Prelease site:stage Notice that the above step 1 disables testing on install and leaves testing to the next step 2 when running site. It seems that one of the steps in the txt file must be leaving some test files behind and the next maven run runs a RAT check and finds these. The two files you found could also be excluded from the RAT check. I just ran step 1 and 2 and I did not get these files created. Of note is that the site to examine is in target/staging It's a pain that the process is a bit different for a multi-module Maven build compared to a single module build. Overall, I would not say this is a blocker. WDYT? Gary On Mon, Oct 19, 2020 at 3:03 AM Bruno P. Kinoshita <ki...@apache.org> wrote: > Checked signatures, and inspected files in the dist area. No issues. > > Tried building following instructions in `BUILDING.txt` but it failed due > to files without license when RAT report was executed. > > Tried again with the commands in the body of your e-mail Gary, but it > failed again on: mvn -V -Ptest-deploy -Prelease -P japicmp -P jacoco site > > > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 08:33 min > [INFO] Finished at: 2020-10-19T19:58:17+13:00 > [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on > project commons-vfs2-jackrabbit2: failed to get report for > org.codehaus.mojo:jdepend-maven-plugin: Failed to execute goal > org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project > commons-vfs2-jackrabbit2: Too many files with unapproved license: 2 See RAT > report in: > /home/kinow/Development/java/apache/commons-vfs/commons-vfs2-jackrabbit2/target/rat.txt > -> [Help 1] > > > > $ git status > HEAD detached at commons-vfs-2.7.0-RC1 > Untracked files: > (use "git add <file>..." to include in what will be committed) > commons-vfs2-jackrabbit2/jackrabbit.log_IS_UNDEFINED > commons-vfs2-jackrabbit2/jetty.log_IS_UNDEFINED > > > > > On Monday, 19 October 2020, 5:13:13 pm NZDT, Gary Gregory < > ggreg...@apache.org> wrote: > > We have fixed a few bugs and added some enhancements since Apache Commons > VFS Project 2.6.0 was released, so I would like to release Apache Commons > VFS Project 2.7.0. > > Apache Commons VFS Project 2.7.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1 (svn > revision 41969) > > The Git tag commons-vfs-2.7.0-RC1 commit for this RC is > 8a34d82ead0780a9ee1f78fd9702e5dbd663070a which you can browse here: > > > https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=8a34d82ead0780a9ee1f78fd9702e5dbd663070a > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git --branch > commons-vfs-2.7.0-RC1 commons-vfs-2.7.0-RC1 > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1534/org/apache/commons/ > > These are the artifacts and their hashes: > > > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0.jar > (SHA1: fe698077c7cfaf82bf07a231deb63b045eb70b98) > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0-test-sources.jar > (SHA1: e48d07f626f75fc3ad6c1c89f918c567d9219426) > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0-tests.jar > (SHA1: 6a6d486fbd9401b28dcdd84ed801bf0cd5539996) > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0-javadoc.jar > (SHA1: 56bd7feab1008c5899915a50b5ede012f1418d7a) > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0.pom > (SHA1: 11d08a780d86ad2f6d4fb4d25d79810b6f2ec431) > /org/apache/commons/commons-vfs2/2.7.0/commons-vfs2-2.7.0-sources.jar > (SHA1: b795105a842138c693ebf679518b38a12e1777dc) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0.jar > (SHA1: 8e69c6dea1b3e02948d17c73e28911e5cbaf8e7b) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0-test-sources.jar > (SHA1: dcd9c32b4f414703501d5d60bc0b401e8dab522e) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0-javadoc.jar > (SHA1: 2cbc1fb4eca472c1ccf1cfc66f53ea1226b3b61b) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0.pom > (SHA1: 42a5f3d6de94382a38355591eb1d8b4898b5fa4a) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0-sources.jar > (SHA1: 2a1e3d1cc086c68ce7d8fe7a6aa06bf46bd083a7) > > /org/apache/commons/commons-vfs2-jackrabbit2/2.7.0/commons-vfs2-jackrabbit2-2.7.0-tests.jar > (SHA1: bea030773c51393a0068e4d503f58c48273a0002) > > /org/apache/commons/commons-vfs2-distribution/2.7.0/commons-vfs2-distribution-2.7.0.pom > (SHA1: fb644241a07d51d4c885a24b08635ba1c4b90129) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0-test-sources.jar > (SHA1: f0174b6b7ba665652786bc1a6911586ee6eac747) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0.jar > (SHA1: 1aa0d94636cd151e0b67a2e746a316d55a017926) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0-javadoc.jar > (SHA1: 06b69c95938e96439428e19d354c23678db862cb) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0-tests.jar > (SHA1: d88e7583aa2c67da137c729f9a1e6df64051f6c4) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0-sources.jar > (SHA1: c4a389c504a0d5dcaf34ccc147f5e7afac6da9b6) > > /org/apache/commons/commons-vfs2-jackrabbit1/2.7.0/commons-vfs2-jackrabbit1-2.7.0.pom > (SHA1: 61b00c1d87ef22643c4b7699a252b45349aa50bc) > > /org/apache/commons/commons-vfs2-examples/2.7.0/commons-vfs2-examples-2.7.0.pom > (SHA1: 767f7444d5cef179303ea913d00b6f0de271aad7) > > /org/apache/commons/commons-vfs2-examples/2.7.0/commons-vfs2-examples-2.7.0.jar > (SHA1: b1acaa6943b0603bb715603ab3d5acc065af102d) > > /org/apache/commons/commons-vfs2-examples/2.7.0/commons-vfs2-examples-2.7.0-sources.jar > (SHA1: 5012e9a84ea1af60482580aede713d501d88ecbe) > > /org/apache/commons/commons-vfs2-examples/2.7.0/commons-vfs2-examples-2.7.0-javadoc.jar > (SHA1: 80b2c58990f5f941f9661f7e787a3c57380e7ffb) > > /org/apache/commons/commons-vfs2-project/2.7.0/commons-vfs2-project-2.7.0.pom > (SHA1: bbbdd1a250fd3fa8d43837357e82b60391ca917a) > > /org/apache/commons/commons-vfs2-project/2.7.0/commons-vfs2-project-2.7.0-site.xml > (SHA1: 110d3ade254a2c7f116684d8d433345c3c34455d) > > > I have tested this with > > mvn -V -Ptest-deploy -Prelease clean install -DskipTests > mvn -V -Ptest-deploy -Prelease -P japicmp -P jacoco site > mvn -V -Ptest-deploy -Prelease deploy > mvn -V -Ptest-deploy -Prelease site:stage > > using: > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: C:\Java\apache-maven-3.6.3\bin\.. > Java version: 1.8.0_261, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_261\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 2.6.0 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1/RELEASE-NOTES.txt > > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1/site/changes-report.html > > Site: > > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1/site/index.html > (note some *relative* links are broken and the 2.7.0 directories are > not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 2.6.0): > > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1/site/commons-vfs2/japicmp.html > > RAT Report: > > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.7.0-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git --branch > commons-vfs-2.7.0-RC1 commons-vfs-2.7.0-RC1 > cd commons-vfs-2.7.0-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which > you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE > reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of > packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > 6) Build the site for a multi-module project > > mvn site > mvn site:stage > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > -the end- >