On 2021-06-27, Gary Gregory wrote: > Catching all unchecked exceptions (UE) and rethrowing as checked exceptions > (CE) feels like both a horror show and an exercise in futility, especially > in order to appease some tool that complains today of one thing which may > complain differently tomorrow, I really don't like that idea on paper.
Independent of the nonsense JFrog does our users have repeatedly tols us they expect Compress to throw an IOException rather than a RuntimeException for broken archives. https://issues.apache.org/jira/browse/COMPRESS-169 fixed in Compress 1.4 ten years ago probably is the first one and it is easy to find many more of this type (COMPRESS-424, COMPRESS-490, COMPRESS-131, COMPRESS-219 ... here I stopped grepping through our changelog). > Let's keep in mind that a CE means one can catch it and try to do something > about it which is definitely not the case for a corrupted archive. I mean, > you can download it again, sure, and end up where you started. This is not quite true. You can not recover from an EOFException either. There are lots of cases where we already throw IOExceptions for irrecoverably corrupt archives today. > IOW, let's do what we think is best, not what some tool some company wants > to sell ("our tool is hard core and found 5 gazillion bugs in the open > source echo system") +1 can't argue with selecting the option we consider best for our users. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
