I'm cancelling this vote again to address some of the issues that Alex found, particularly the method naming convention issue.
Alex, The behavior you described for the AbstractNode.depth() method is as designed. It is not sufficient for a node to not have a parent in order to be considered a root node; it must have been explicitly set as the root in the parent tree. This is done with the AbstractBSPTree.setRoot() method, which calls AbstractNode.makeRoot() and initializes the depth to 0. I've addressed some of the issues you mentioned in a new PR [1]. Please take a look and let me know if you think it's good to go. If so, I can try to get another RC out today. Regards, Matt J [1] https://github.com/apache/commons-geometry/pull/181 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
