I ran into an error building from the source distribution on Windows. C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src> mvn -v Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Users\matt\tools\apache-maven-3.6.3-bin\apache-maven-3.6.3\bin\.. Java version: 11.0.12, vendor: Eclipse Foundation, runtime: C:\Program Files\Eclipse Foundation\jdk-11.0.12.7-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src>mvn clean package site site:stage -Pcommons-rng-examples ... [INFO] Reactor Summary for Apache Commons RNG 1.4: [INFO] [INFO] Apache Commons RNG ................................. FAILURE [ 4.472 s] [INFO] Apache Commons RNG Client API ...................... SKIPPED [INFO] Apache Commons RNG Core ............................ SKIPPED [INFO] Apache Commons RNG Simple .......................... SKIPPED [INFO] Apache Commons RNG Sampling ........................ SKIPPED [INFO] Apache Commons RNG Examples ........................ SKIPPED [INFO] Apache Commons RNG Examples Stress Utilities ....... SKIPPED [INFO] Apache Commons RNG Examples Sampling Utilities ..... SKIPPED [INFO] Apache Commons RNG Quadrature Example .............. SKIPPED [INFO] Apache Commons RNG JMH Benchmark ................... SKIPPED [INFO] Apache Commons RNG JPMS Integration Test ........... SKIPPED [INFO] Apache Commons RNG JPMS Module Example (Library) ... SKIPPED [INFO] Apache Commons RNG JPMS Module Example (Application) SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 5.207 s [INFO] Finished at: 2021-09-05T08:43:29-04:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project commons-rng-parent: Too many files with unapproved license: 1 See RAT report in: C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src\target\rat.txt -> [Help 1] The failed file is site-content.README. In commons-geometry, I had to explicitly add this file to the rat excludes in the pom in order to get the build to pass. I also noticed that the userguide Dependencies section still lists the required Java version as 1.7+. I don't consider that a blocker in itself but we might want to update that as well. Everything else looks good. Regards, Matt J On Sat, Sep 4, 2021 at 12:58 PM Alex Herbert <[email protected]> wrote: > > Note it also prevents a site build if you don't have SVN installed. > > My previous changes to this were to continue its support but improve it to > a minimal download. I'll move this functionality to a profile as it is only > of concern when updating the site. > > Alex > > On Sat, 4 Sep 2021, 14:46 Gilles Sadowski, <[email protected]> wrote: > > > Hello. > > > > Le ven. 3 sept. 2021 à 09:32, Alex Herbert <[email protected]> a > > écrit : > > > > > > Hi, > > > > > > On Fri, 3 Sept 2021 at 00:29, Gilles Sadowski <[email protected]> > > wrote: > > > > > > > > > > > > > > I noticed that missing "site-content" directories still lead to the > > > > contents being downloaded as part of the build. > > > > I thought the "fix" was that it would not occur by default; or did > > > > I miss something? > > > > > > > > > > The current solution is that the top-level directory of the existing site > > > is checked out in the parent module (i.e. non recursive site checkout). > > So > > > you do get a few files logged by maven as being checked out during the > > > 'site' goal. There should be a 'site-content.README' file created which > > > contains information about the site-content directory. It has to be > > outside > > > the site-content directory. In all the child modules an otherwise empty > > > site-content directory is created with a README inside to indicate why it > > > is there. A repeat of the site build should detect all the directories > > are > > > present and not invoke the checkout again. > > > > > > All this should be removed by using the 'clean' goal. > > > > > > Are you getting a total site checkout or just the solution I described? > > > > It works as you describe. > > > > Taking a step back, I'm still missing why there is any download > > from SVN in order to fulfill the "site" target (a local build of the site > > from the source release should not need "external" material, IIUC). > > > > Regards, > > Gilles > > > > > [...] > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
