Crafting a compressed file for a test fixture that causes a integer overflow deep in our code would be quite hard to reverse engineer.
Gary On Wed, Feb 9, 2022, 09:38 Gilles Sadowski <gillese...@gmail.com> wrote: > Le mer. 9 févr. 2022 à 15:16, Gary Gregory <garydgreg...@gmail.com> a > écrit : > > > > Observe > > Perhaps I'm dense, but my detailed remark about the commit > reflects that I did. > > > that ExactMath delegates to Math after performing the necessary > > additional Math calls. > > As per the first part of the remark, it is not obvious why those > hoops are necessary; thus documenting the rationale would > prevent someone scrapping them (with just as terse a commit > message). > The other part of the remark signals a potential bug and/or > unintended behaviour; this also calls for clarification (and/or > unit tests). > > Thanks, > Gilles > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
