Hi, If you run 'mvn pmd:check' on Commons Text, you'll get:
<?xml version="1.0" encoding="UTF-8"?> <pmd xmlns="http://pmd.sourceforge.net/report/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://pmd.sourceforge.net/report/2.0.0 http://pmd.sourceforge.net/report_2_0_0.xsd"; version="6.46.0" timestamp="2022-06-01T08:42:15.132"> <file name="/Users/garydgregory/git/commons-text/src/main/java/org/apache/commons/text/RandomStringGenerator.java"> <violation beginline="85" endline="85" begincolumn="44" endcolumn="97" rule="UnnecessaryFullyQualifiedName" ruleset="Code Style" package="org.apache.commons.text" class="RandomStringGenerator$Builder" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_codestyle.html#unnecessaryfullyqualifiedname"; priority="4"> Unnecessary use of fully qualified name 'org.apache.commons.text.Builder' due to existing same package import 'org.apache.commons.text.*' </violation> </file> <file name="/Users/garydgregory/git/commons-text/src/main/java/org/apache/commons/text/StrBuilder.java"> <violation beginline="2033" endline="2033" begincolumn="13" endcolumn="21" rule="AvoidBranchingStatementAsLastInLoop" ruleset="Error Prone" package="org.apache.commons.text" class="StrBuilder" method="indexOf" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_errorprone.html#avoidbranchingstatementaslastinloop"; priority="2"> Avoid using a branching statement as the last in a loop. </violation> <violation beginline="2374" endline="2374" begincolumn="17" endcolumn="25" rule="AvoidBranchingStatementAsLastInLoop" ruleset="Error Prone" package="org.apache.commons.text" class="StrBuilder" method="lastIndexOf" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_errorprone.html#avoidbranchingstatementaslastinloop"; priority="2"> Avoid using a branching statement as the last in a loop. </violation> </file> <file name="/Users/garydgregory/git/commons-text/src/main/java/org/apache/commons/text/StrLookup.java"> <violation beginline="137" endline="139" begincolumn="19" endcolumn="17" rule="EmptyCatchBlock" ruleset="Error Prone" package="org.apache.commons.text" class="StrLookup$SystemPropertiesStrLookup" method="lookup" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_errorprone.html#emptycatchblock"; priority="3"> Avoid empty catch blocks </violation> </file> <file name="/Users/garydgregory/git/commons-text/src/main/java/org/apache/commons/text/TextStringBuilder.java"> <violation beginline="2057" endline="2057" begincolumn="13" endcolumn="21" rule="AvoidBranchingStatementAsLastInLoop" ruleset="Error Prone" package="org.apache.commons.text" class="TextStringBuilder" method="indexOf" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_errorprone.html#avoidbranchingstatementaslastinloop"; priority="2"> Avoid using a branching statement as the last in a loop. </violation> <violation beginline="2390" endline="2390" begincolumn="17" endcolumn="25" rule="AvoidBranchingStatementAsLastInLoop" ruleset="Error Prone" package="org.apache.commons.text" class="TextStringBuilder" method="lastIndexOf" externalInfoUrl="https://pmd.github.io/pmd-6.46.0/pmd_rules_java_errorprone.html#avoidbranchingstatementaslastinloop"; priority="2"> Avoid using a branching statement as the last in a loop. </violation> </file> </pmd> The first once seems like a bug in PMD, does anyone agree. If you have a solution for the AvoidBranchingStatementAsLastInLoop issue, I'd welcome a PR :-) Gary --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
