On Wed, 19 Oct 2022 at 14:52, <sma...@outlook.de> wrote:
>
> > You have added test data for CSVFormat for 1.7 and 1.8 and these do
> not work (commented out). I take it this means serialization has been
> broken since the CSVFormat.delimiter was changed from char to String
> in 1.9.0.
>
> That's correct, Alex. I added the comments for documentation. Should we 
> decide to fix serialization from version 1.7 and version 1.8 upwards, the 
> test and test data can be enabled.
>
> > So given serialization was already broken in the last
> release does it make any sense to fix it for 1.9.0 to 1.10.0 for the new 
> field?
>
> According to the number of Maven central downloads versions 1.8 and 1.9.0 are 
> the most popular of commons-csv.
> So I think there is merit in fixing serialization issues from 1.9.0 to 1.10.0 
> Besides the PR already offers the fix, why abandon it?

Serialization is already broken for CSVRecord from 1.7+. It is broken
for CSVFormat 1.7+. It will be removed in 2.0. So I think that
serialization should be ignored going forward.

>
> Will PR #276 be part of version 1.10.0?

Perhaps it should be.

Alex

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to