On Thu, 20 Oct 2022 at 23:43, Alex Herbert <alex.d.herb...@gmail.com> wrote: > > I did not have time to track through whether this behaviour changed > after the initial implementation of the flag. I would think not as the > original behaviour is from 1.0. This would map to: > > true -> ALLOW_ALL > false -> ALLOW_EMPTY > new -> DISALLOW > > Which is what we currently have in 1.10.0 RC1. Thus the PR #276 [7] to > change the use of the flag to 'false -> DISALLOW' is not maintaining > behavioural compatibility (to 1.7, or back to 1.0).
PS. I just verified that PR 276 changes the DuplicateHeaderMode value for allowDuplicates=false and does not change any tests. So the test suite is currently not enforcing behavioural compatibility. This seems like a glaring hole in the tests and should be addressed to prevent regressions. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
