On 2022/11/02 16:41:30 Mark Roberts wrote: > In the constructor of > /src/main/java/org/apache/bcel/verifier/structurals/ExceptionHandlers.java - > the 'computeIfAbsent' line is duplicated. Is this correct?
Good spot, luckily the semantics are the same (the key will be present on the 2nd invocation); I'll fix it post-release. Gary > > Mark > > -----Original Message----- > From: Gary D. Gregory [mailto:ggreg...@apache.org] > Sent: Tuesday, November 1, 2022 10:17 AM > To: dev@commons.apache.org > Subject: Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2 > > ping :-) > > On 2022/10/29 16:35:28 Gary Gregory wrote: > > We have fixed a regression bug since Apache Commons BCEL 6.6.0 was > > released, so I would like to release Apache Commons BCEL 6.6.1. > > > > Apache Commons BCEL 6.6.1 RC2 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 (svn > > revision 57656) > > > > The Git tag commons-bcel-6.6.1-RC2 commit for this RC is > > eda94276de5d01c81e73ab2f165a49e841c7b69f which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=eda9 > > 4276de5d01c81e73ab2f165a49e841c7b69f > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > > --branch > > commons-bcel-6.6.1-RC2 commons-bcel-6.6.1-RC2 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-16 > > 05/org/apache/bcel/bcel/6.6.1/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sat Oct 29 12:22:19 EDT 2022 > > Apache\ Commons\ > > BCEL-6.6.1.spdx.rdf.xml=4f97b219f60290e0795999cf3c3483d2738dd429ca013f > > 764b20078a6f799200ff958a14cb4cc03c73f30b58836bf59229ce6ee4f5e94022df8b > > 533000946c84 > > bcel-6.6.1-bin.tar.gz=7826733c3d139e52b6022d5df7430c391bd3b93707ef99f5 > > 803390cb91f4ba0b87b073ca4e208869c5bd453f40739631ad8d6ab5ed3cbbc9270a5d > > c0345238f4 > > bcel-6.6.1-bin.zip=d1c2fca54a5d5acc8edae097a7383dd56eb324a73f343da901b > > 0b1ea50b6a01910674e2f7f4497e8ac299fef25afb0060399c3aadbbabb879356f6fb0 > > b4389ad > > bcel-6.6.1-bom.json=fb408f3f439fd0dcaef0ca6b2bf309bc6aac523096a12f7e5b > > af6374fa05f7d9f919b0ce520ceaf08b51960d8483f638d4e2ce5bd0994168786354bf > > 02866dd4 > > bcel-6.6.1-bom.xml=7ef7417e5ef7f4443b4faba6cbc0c32b88522cf359d5de9a50e > > ad505070bb7ef779a18c9cad0aeaab6cf458f7c700ca3548a63f7d0a2804f73a527299 > > 9f62855 > > bcel-6.6.1-javadoc.jar=9a58c07addcb18f4a567418abf9e8d75e17ba6f05de0f95 > > 6797890bfb4d1d8a8403d03f8cf947b4f48d9fc8c98276befb9fb2060e526dfd44e96e > > e3e755047e0 > > bcel-6.6.1-sources.jar=6de8e778b0e82b3004c3d6041fa451ccf4a3a10ec61d1ff > > b1cf39287ea49440018d9d3ba06acad6de6e2b3cfd9d58737f5696ed8b20b3ba9ab5fd > > 642e7ae2aac > > bcel-6.6.1-src.tar.gz=d746bee8f0c3483fe589845a1a843043e6162970751e1e21 > > a30f01f122556a1b9d52a8c7d808db91671f0f2324ff871ba5f571fc369bb77d232680 > > 654cbb77b4 > > bcel-6.6.1-src.zip=6759324529a42e45ffdd449cddf01dade57459b86a4820550d5 > > a859ff1eca85057a9343ae217def029d9f8e4b3365b49f692522a2e75cd1dc4806b8f9 > > 09c613a > > bcel-6.6.1-test-sources.jar=604df990454feb5976b9f0b763bdbd50a434bb1db2 > > 6d9876a555195ca42d99a3b6b84b2718ac925896a9bb2c05f0633d4cb275fe69574183 > > 6fe9aa0cb18d4db3 > > bcel-6.6.1-tests.jar=0f1b1396d376cc0f2c69e897817b0a7b24db282cf7122d895 > > dabe70aa1b7d0faf4348cae4cb01e4d93224552f4db77fdd86af11c69574635b282e74 > > b451a689e > > > > > > I have tested this with 'mvn -V -Duser.name=$my_apache_id -Prelease > > -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: > > > > Darwin **** 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 > > PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 Apache Maven > > 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > > Java version: 1.8.0_345, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@8/1.8.0+345/libexec/openjdk.jdk/Contents/Hom > > e/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os > > x", version: "12.6", arch: "x86_64", family: "mac" > > > > Details of changes since 6.6.0 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2/RELEASE- > > NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2/site/cha > > nges-report.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2/site/index.html > > (note some *relative* links are broken and the 6.6.1 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 6.6.0): > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2/site/jap > > icmp.html > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2/site/rat > > -report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > > --branch > > commons-bcel-6.6.1-RC2 commons-bcel-6.6.1-RC2 cd > > commons-bcel-6.6.1-RC2 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
