Hi Alex, Thank you for your review. I cannot reproduce your error. I tested locally now with commons-parent git master 55-SNAPSHOT with commons-text (the component I tested for the RC), commons-lang, and commons-rng.
For 'mvn install -DskipTests', I see output like: ... [INFO] <<< spdx-maven-plugin:0.6.3:createSPDX (build-spdx) < verify @ commons-lang3 <<< [INFO] [INFO] [INFO] --- spdx-maven-plugin:0.6.3:createSPDX (build-spdx) @ commons-lang3 --- [INFO] Creating SPDX File C:\Users\ggregory\git\a\commons-lang\target\site\org.apache.commons_commons-lang3-3.13.0-SNAPSHOT.spdx.json [WARNING] Unable to map maven licenses to a declared license. Using NOASSERTION [WARNING] Could not determine the SPDX relationship type for dependency artifact ID commons-text scope provided [WARNING] Could not determine the SPDX relationship type for dependency artifact ID commons-lang3 scope provided [INFO] ... My output for commons-rng is here: https://paste.apache.org/sml51 All I did is edit the parent POM version in the root pom.xml I am running with: Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: C:\java\apache-maven-3.8.6 Java version: 1.8.0_352, vendor: Temurin, runtime: C:\Program Files\Eclipse Adoptium\jdk-8.0.352.8-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Microsoft Windows [Version 10.0.19044.2251] Gary On 2022/12/08 13:18:46 Alex Herbert wrote: > Hi Gary, > > I tried with the latest git master for numbers, rng and lang. The > updated spdx-maven-plugin is not compatible with java 8. I get the > following error: > > [ERROR] Failed to execute goal > org.spdx:spdx-maven-plugin:0.6.3:createSPDX (build-spdx) on project > commons-lang3: Execution build-spd > x of goal org.spdx:spdx-maven-plugin:0.6.3:createSPDX failed: An API > incompatibility was encountered while executing org.spdx:spdx-ma > ven-plugin:0.6.3:createSPDX: java.lang.UnsupportedClassVersionError: > org/spdx/spdxRdfStore/RdfStore has been compiled by a more recen > t version of the Java Runtime (class file version 55.0), this version > of the Java Runtime only recognizes class file versions up to 5 > 2.0 > > mvn -v > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /usr/local/apache-maven-3 > Java version: 1.8.0_352, vendor: Private Build, runtime: > /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-200-generic", arch: "amd64", family: "unix" > > Note: I am not clear exactly what the issue is as it does not happen > in the first jar module of the rng project reactor. The first module > commons-rng-client-api has no dependencies and this builds ok. The > next module commons-rng-core only depends on the client-api. This also > builds. The reactor breaks on the simple module which depends on core > and the client-api. However in numbers the reactor breaks on the first > module commons-numbers-core. This has no runtime dependencies. So some > part of the spdx plugin is being invoked only in some modules that has > a class compiled for Java 11. > > Building under JDK 11 was fine for all 3 named projects. > > Note that numbers and rng previously had <cylconedx.skip> set to true > as the configuration in CP 54 broke the build. I changed to false and > the multi-module build was fine. > > mvn -v > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /usr/local/apache-maven-3 > Java version: 11.0.17, vendor: Ubuntu, runtime: > /usr/lib/jvm/java-11-openjdk-amd64 > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-200-generic", arch: "amd64", family: "unix" > > So cyclonedx is fixed, but spdx is now not Java 8 compatible. > > Alex > > On Wed, 7 Dec 2022 at 19:50, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > We made some enhancements since Apache Commons Parent 54 was released, > > so I would like to release Apache Commons Parent 55. > > > > This is the parent POM for Apache Commons, it doesn't contain Java > > code, and therefore no JApiCmp API compatibility check or report on > > the site. > > > > Apache Commons Parent 55 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1 > > (svn revision 58537) > > > > The Git tag commons-parent-55-RC1 commit for this RC is > > 1a8382d227787216d76c1fea62b641158d0a265e which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=1a8382d227787216d76c1fea62b641158d0a265e > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > --branch commons-parent-55-RC1 commons-parent-55-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1611/org/apache/commons/commons-parent/55/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Wed Dec 07 14:37:02 EST 2022 > > commons-parent-55-bom.json=e96e4d8f44b900ae5b12abbf81c1fa9a5c28e13c0767290e85c0f9e0486c9b3d2f6dac6ba8f4ca3f25c00716b5b6c180f16e0cfa17a51b1fd3c63c57f13deded > > commons-parent-55-bom.xml=11bdf25c251b8b99f5684740e05fa08e8ad01dddeb6544327083696a578bc48785a8d27d03cd7b1ce8f3ace8f4e1b60d32819e4a3b6bc1ed775be5d549e32d33 > > commons-parent-55-site.xml=735ffceca46a0574d430b4e1213a2462b9475143c0788913312b8af117eaf3b7c02a075aaf6d9b30d2560822339651cb511b838f6c9f2bced46de1fc1227c5ff > > commons-parent-55-src.tar.gz=1a0307090faca60eaf8a034201521262828c283c8e51dd92a1add0adf48bb55898e0d990daa407648e7b65d6e85a7629ecfb30f4195fbc47d6bf0d14e9664254 > > commons-parent-55-src.zip=13c5158f0957853e1df39aa5aa03180b404caa727fef276c969bc811de1e6b3b5465341d544869b338597805b085c21fee63b3d2f6f42dd93dd297fe5e6c8cda > > org.apache.commons_commons-parent-55.spdx.json=14f27b64c60287116e84e2ae9b4d66017260287962c29baef621e9e2b06c06578768453a05bafa90cbe1aa2fe04e248aaedf9b64e8683c658452dedd798e8538 > > > > I have tested this with 'mvn clean install' using: > > > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > > Java version: 1.8.0_352, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@8/1.8.0+352/libexec/openjdk.jdk/Contents/Home/jre > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "13.0.1", arch: "x86_64", family: "mac" > > Darwin **** 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:14:54 > > PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64 > > > > Details of changes since 54 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1/site/changes-report.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1/site/index.html > > (note some *relative* links are broken and the 55 directories are > > not yet created - these will be OK once the site is deployed.) > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > garydgregory, > > Release Manager (using key DEADBEEF) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > --branch commons-parent-55-RC1 commons-parent-55-RC1 > > cd commons-parent-55-RC1 > > > > 1b) Download and unpack the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/55-RC1/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > 6) Build the site for a multi-module project > > > > mvn site > > mvn site:stage > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > Note that the project reports are created for each module. > > Modules can be accessed using the 'Project Modules' link under > > the 'Project Information' menu (see <path-to-site>/modules.html). > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
