+1 ASC OK SHA512 OK
These are not showstoppers but they should be addressed at some point: - I'd prefer we always use M.M.M version formats, here 3.2.0. - This site page incorrectly lists links to the RC instead of what will be the real page https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/scm.html - Misaligned source code example: https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/CacheEventLogging.html - https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/RemoteHttpCacheProperties.html -- "http" in text is an acronym and should be uppercase "HTTP" -- Same for "url" should be "URL" -- Same for "uri" should be "URI" -- Look for other commons acronyms - Should source incompatibilities listed in the JApiCmp report also be listed in the release notes? Build OK with `mvn` using Java 8, 11, 17, and 20: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 1.8.0_382, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@8/1.8.0+382/libexec/openjdk.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "13.5.1", arch: "x86_64", family: "mac" Darwin **** 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64 Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 11.0.20.1, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@11/11.0.20.1/libexec/openjdk.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "13.5.1", arch: "x86_64", family: "mac" Darwin **** 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64 Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 17.0.8.1, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "13.5.1", arch: "x86_64", family: "mac" Darwin **** 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64 Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 20.0.2, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-20.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "13.5.1", arch: "x86_64", family: "mac" Darwin **** 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64 Gary On Sun, Sep 3, 2023 at 11:51 AM Thomas Vandahl <t...@apache.org> wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons JCS 3.1 was released, so I would like to release Apache > Commons JCS 3.2. > > Apache Commons JCS 3.2 rc1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1 (svn revision > 63581) > > The Git tag commons-jcs3-3.2-rc1 commit for this RC is > 6ff84134fa295b608531f9655f075ea58635cd57 which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-jcs.git;a=commit;h=6ff84134fa295b608531f9655f075ea58635cd57 > > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-jcs.git --branch > commons-jcs3-3.2-rc1 commons-jcs3-3.2-rc1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1650/org/apache/commons/commons-jcs3/3.2/ > > These are the release artifacts and their hashes: > > 6fb8c140c49229339ccea583c462e20b5f2abfd13b3615f466e5b7e44abfbfa7f662ce25b54edcf433c2b7010e4b32c2cde09f2da7754d7f697e871b76f61c91 > commons-jcs3-dist-3.2-bin.tar.gz > 6d2c47f3e41a6fca3fa94dd423d8e9c4bc76929778d5d44ee094a2d8465f1449feffee24ee1248e80baaec8e2c08051ff3fdcae76610591b451e796904f5dd46 > commons-jcs3-dist-3.2-bin.zip > 16c8bb7abe9268a39b80ce03a57adf1ac596191e4aee80756443d1861b850ffe5b67f6fbd9d46f1189d4247b7b928192cb7fb28f45e8bc768317972276acac9a > commons-jcs3-dist-3.2-src.tar.gz > 1f78fdc0be26f0b8b350ef2623191a28e13131b6a98abc51927aada192b7b381d1d7264a2083f23a72bf0906a0e4164e0c2a5aee11c3448408399cc87f0b912e > commons-jcs3-dist-3.2-src.zip > > I have tested this with ***'mvn clean install site site:stage'*** using: > > Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) > Java version: 1.8.0_311, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk1.8.0_311.jdk/Contents/Home/jre > Default locale: de_DE, platform encoding: UTF-8 > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > > Details of changes since 3.1 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/changes-report.html > > Site: > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/index.html > (note some *relative* links are broken and the 3.2 directories are not yet > created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 3.1): > > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/commons-jcs3-core/japicmp.html > > *** > Note that the above report notes several errors. > These are considered OK for the reasons stated below. > These exceptions are also noted in the Changes and Release Notes. > > Errors reported: > - methods added to interface: OK because that does not affect binary > compatibility. > - annotation @Deprecated added to classes > *** > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/jcs/3.2-rc1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Thomas Vandahl (tv), > Release Manager (using key 88817402) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-jcs.git --branch > commons-jcs3-3.2-rc1 commons-jcs3-3.2-rc1 > cd commons-jcs3-3.2-rc1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > 6) Build the site for a multi-module project > > mvn site > mvn site:stage > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > -the end- > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
