Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

[Gary Gregory]

Hi,

Thank you for your email.

I can't validate this without a test. The best path forward is for you to
provide a PR in GitHub.

TY!
Gary

On Mon, Feb 12, 2024, 10:15 AM Емельянов Юрий Владимирович
<emelya...@krista.ru.invalid> wrote:

> see FTPHTTPClient.tunnelHandshake
>
> current code is:
>
>          if (proxyUsername != null && proxyPassword != null) {
>              final String auth = proxyUsername + ":" + proxyPassword;
>              final String header = "Proxy-Authorization: Basic " +
> Base64.getEncoder().encodeToString(auth.getBytes(charset));
>              output.write(header.getBytes(charset));
>          }
> correct code is:
>
>          if (proxyUsername != null && proxyPassword != null) {
>              final String auth = proxyUsername + ":" + proxyPassword;
>              final String header = "Proxy-Authorization: Basic " +
> Base64.getEncoder().encodeToString(auth.getBytes(charset));
>              output.write(header.getBytes(charset));
> *output.write(CRLF);*
>          }
>
>