Could we get more reviews please? TY! Gary
On Wed, Mar 20, 2024, 3:42 PM Rob Tompkins <chtom...@gmail.com> wrote: > +1 looks good > > > On Mar 17, 2024, at 11:44 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > We have fixed a few bugs and added some enhancements since Apache > > Commons Logging 1.3.0 was released, so I would like to release Apache > > Commons Logging 1.3.1. > > > > (Note that the new release candidate is labeled 1.3.1 and no longer > 1.4.0.) > > > > Apache Commons Logging 1.3.1 RC2 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2 > > (svn revision 67979) > > > > The Git tag commons-logging-1.3.1-RC2 commit for this RC is > > 558bb9cdd5fb06e313214d34ed5be7de5f000a5a which you can browse here: > > > https://gitbox.apache.org/repos/asf?p=commons-logging.git;a=commit;h=558bb9cdd5fb06e313214d34ed5be7de5f000a5a > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-logging.git > > --branch commons-logging-1.3.1-RC2 commons-logging-1.3.1-RC2 > > > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1704/commons-logging/commons-logging/1.3.1/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sun Mar 17 15:39:38 UTC 2024 > > > commons-logging-1.3.1-sources.jar=2b80051bc2a6478ac2ba7c0dc3de0ec7b14976b1d2ed62fde050fb40920d9904ce2e1fa168155780f900592152f9d433555c4fdfbb669455abbc132030b7404a > > > commons-logging-1.3.1-src.tar.gz=ffda970d086601df4b476caf8bd01d1bdc22dd7f8846a22287036f7f000ce6cf0a757d16621910f041f8d90aa6066819454b3977dd005ca66817bec59e91e91f > > > commons-logging-1.3.1-javadoc.jar=da92f1a875c84174ea81e5b61be6d96aebed0460a129484f15552e7ecc14a8f5a886433278524bcca53f07373bf08ffd3c0e66d755ba084e1babddb0d815db99 > > > commons-logging-1.3.1-test-sources.jar=30ad1e42723bf10bb170f04415af56aad8803f385b278c62b295bd4512874080b63daa71c08f119b5cd25d064eebe018a6cd64fa5a4ecc0cb129225977795f60 > > > commons-logging-1.3.1-src.zip=ccd55350243b12d9a43385a32fb86ed3e3f8c84b68f3b009598c9f77d2659d34532e100d371810a6bdb31d495223200ea59f1e4ae4b0e9d7ee24b9410de037d6 > > > commons-logging-1.3.1-adapters.jar=b67193bbad0a161dd79c23cf683553cb7dcfe19f234324c9457991605198002fe4bdddd4e772c7f7463b9d2017a635fd3d22632d4d22408f9fa79586a36a817b > > > commons-logging-1.3.1-api.jar=14aaf1d4b5430f590a2f98575143b2b531bcd0527f4cd2c754242a46ab2df80426e731059c9fceea2d78321f849ddb20296250f875100b5899c9321dc0130020 > > > commons-logging-1.3.1-bom.json=55d7b79e697cf84f9e5e3255dd2e725a1b4c205e4e64043795f91067bc577ba8aaba314972f59def246846c04285fe3c03cf55f2d4612674c36ac015d9fbf061 > > > commons-logging_commons-logging-1.3.1.spdx.json=4ef75823dab414487f44e2abbf849248e9e123b8b1c7504fe963cc3e668789fa10ed64e0eea360a8342fd614779936853c4bba826832457a0ee234b728ae3079 > > > commons-logging-1.3.1-bin.tar.gz=d1897232f7734957baf19f1fcc60da64ae36be06985ad63260e6d752a03cbfc23aec7d3865e908436d66fa1ba121dd81ba5e0b79dad4143dfa41c1857d3f6d20 > > > commons-logging-1.3.1-bom.xml=68db0d81784aac3d5a727c09163d115e52adac317c4657ecf8bd9cfd98321da92593c8615e38f9e79e4af782f71344c03cf7c51008b15af4fdea404692fef446 > > > commons-logging-1.3.1-bin.zip=751d971db549541b5f41ae16fc9cdebfec319494d3f0ce58757dbeb6f067036e1eabe4962c326e23fcabf2b66d5602ee9fde302865287ef2a48154c1ccb6d6ec > > > commons-logging-1.3.1-tests.jar=43da256ca13506bbe3e330847b14c873e627cfa4495c554a5d4f9ca62032816fe06e304f48089c79078d58e9f376e54cbe5e762d9be0a7c60da5f8898bf1d496 > > > > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P > > jacoco -P japicmp clean package site deploy' using: > > > > openjdk version "17.0.10" 2024-01-16 > > OpenJDK Runtime Environment Homebrew (build 17.0.10+0) > > OpenJDK 64-Bit Server VM Homebrew (build 17.0.10+0, mixed mode, sharing) > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > > Java version: 17.0.10, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@17/17.0.10/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.3.1", arch: "x86_64", family: "mac" > > > > Darwin **** 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:28:58 > > PST 2023; root:xnu-10002.81.5~7/RELEASE_X86_64 x86_64 > > > > Details of changes since 1.3.0 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/RELEASE-NOTES.txt > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/site/changes-report.html > > > > Site: > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/site/index.html > > (note some *relative* links are broken and the 1.3.1 directories > > are not yet created - these will be OK once the site is deployed.) > > > > *** CLIRR Report (compared to 1.3.0): > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/site/clirr-report.html > > > > *** JApiCmp Report (compared to 1.3.0): > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/site/japicmp.html > > > > *** > > Note that the above report notes several errors. > > These are considered OK for the reasons stated below. > > These exceptions are also noted in the Changes and Release Notes. > > > > Errors reported: > > - methods added to interface: OK because that does not affect > > binary compatibility. > > - etc. > > *** > > > > RAT Report: > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-logging.git > > --branch commons-logging-1.3.1-RC2 commons-logging-1.3.1-RC2 > > cd commons-logging-1.3.1-RC2 > > > > 1b) Download and unpack the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/logging/1.3.1-RC2/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
