My +1 Gary
On Wed, May 29, 2024 at 4:35 AM Henri Biestro <hen...@apache.org> wrote: > > [ +1 ] LGTM > > Site & Javadoc look good, changes & JIRA report clean (nice!), nit: Jacoco > report missing some classes > > Built using: > mvn clean install site -Pjacoco -s ~/.m2/commons-settings.xml > On: > mvn -version > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 > Java version: 1.8.0_352, vendor: Azul Systems, Inc., runtime: > /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "14.5", arch: "aarch64", family: "Mac" > And: > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 > Java version: 17.0.8, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac" > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
