Hello.

Le mar. 9 juil. 2024 à 14:22, Alex Herbert <aherb...@apache.org> a écrit :
>
> We have fixed a few bugs and added enhancements since Apache Commons RNG
> 1.5 was released, so I would like to release Apache Commons RNG 1.6.
>
> Apache Commons RNG 1.6 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2 (svn
> revision 70197)
>
> The Git tag commons-rng-1.6-RC2 commit for this RC is commons-rng-1.6-RC2
> which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.6-RC2
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.6-RC2 commons-rng-1.6-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng/1.6/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Jul 09 12:29:41 BST 2024
> commons-rng-1.6-bin.tar.gz=ede8acdf030d658d5ee2164185cb4e4e3b402f3b7032202d29016df76946f1355c0e968677fcae6eafcff3a8d6439c70e3514013c07fa34048c3f33e2005e7e4
> commons-rng-1.6-bin.zip=6011e1ea66226592168e6fb67d0c2740cf537edc0d4b549423e5ba7761084cb7222982fdf09ef9a6b8ea29c45e4a6cd09137d4d9ffd20172008f26a8a0804486
> commons-rng-1.6-src.tar.gz=8cb6e78b7a27aaf9492f549848465987838fd490a97996c5f7d516a648093db777d63544cd4be7550de22d69b80b070fdfa5e1f6dd143c2e75c70db684a39e2e
> commons-rng-1.6-src.zip=57e999f5f76155046cde915eaf33781f6361588a5e0d8776d4451149eca4d07fcf2b49612c5e6829181b75ad697e60f6243c0fedff0d932130315e44fe0a3237
>
> Signatures may be validated on a system supporting a bash Unix shell by
> executing:
>     svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/
>     cd 1.6-RC2
>     chmod +x ./signature-validator.sh
>     for m in client-api core simple sampling bom; do
> ./signature-validator.sh
> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng-${m}/1.6/;
> done

It would be worth reminding that a copy/paste of the above on the
command-line will not work (although the script outputs both "ERROR"
and "SUCCESSFUL VALIDATION" which is confusing/misleading).

Couldn't the script be auto-generated (rather than just copied I presume)
to also contain the "for-loop" specific to each component?

> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
>
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
>
> I have tested this with 'mvn clean install' and 'mvn clean package site
> site:stage -Pcommons-rng-examples' using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /Users/ah403/software/apache-maven-3
> Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
> /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
>
>
> Details of changes since 1.5 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/RELEASE-NOTES.txt
>
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/changes-report.html
>
> Site:
>     https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/index.html
>     (note some *relative* links are broken and the 1.6 directories are not
> yet created - these will be OK once the site is deployed.)

The site there looks quite fine (i.e. it does not display the layout
issues which
I mentioned in the other message).

Also the Revapi is not empty, as in the site I generated locally.

Several ways to run maven below... It would be better to have only the one
expected to produce all the items suggested to be checked.
Still I maintain that the "site" and "site:stage" are causing trouble that
unnecessarily complicates the release (both for the manager and the
reviewer).  The steps (2) and (3) in the "validating" list should be automated
(as they are in [RNG] at least) and assumed to pass if the (single) maven run
completes successfully...

>
> KEYS:
>   https://downloads.apache.org/commons/KEYS

I seem to recall that it was also suggested to run
  $ git tag -v commons-rng-1.6-RC2

Did it become obsolete?

>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
   [X] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>

Regards,
Gilles

>
> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to