I'll ping this thread when there is something in git master to test in more depth.
Gary On Wed, Sep 25, 2024 at 4:01 PM Josh Fenlason <josh.fenla...@veritas.com.invalid> wrote: > > Excellent, thanks for that encouraging update! Is there anything I can > assist with? > Josh. > > -----Original Message----- > From: Gary Gregory <garydgreg...@gmail.com> > Sent: Wednesday, September 25, 2024 2:52 PM > To: Commons Developers List <dev@commons.apache.org> > Subject: Re: [beanutils] For 2.0, WeakFastHashMap vs ConcurrentHashMap > > > CAUTION: This email originated from outside the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. If you believe this is a phishing email, use the Report to > Cybersecurity icon in Outlook. > > > > FWIW, I have a patch in progress using the Apache Grooy's version of the > class, so licensing will not be an issue, Apache to Apache. > > If you look at the recent commits in git master, you'll see that I've started > adding missing tests we need before we add anything else... > > I also have tests written that fit in the existing test framework. > These will likely need to be beefed up. I saw zero tests for this class in > the Groovy code base. > > Stay tuned. > > Gary > > On Wed, Sep 25, 2024 at 3:37 PM Josh Fenlason > <josh.fenla...@veritas.com.invalid> wrote: > > > > Are legal concerns of using Netty's ConcurrentWeakKeyHashMap the only issue > > with Melloware's PR (https://github.com/apache/commons-beanutils/pull/56) > > from a couple of years ago? That PR mentions > > http://creativecommons.org/licenses/publicdomain for details on the > > license, which unfortunately no longer works. However, looking at the > > Netty source > > (https://github.com/netty/netty/blob/3.9/src/main/java/org/jboss/netty/util/internal/ConcurrentWeakKeyHashMap.java), > > they have an Apache 2 license. Doesn't that alleviate any license > > concerns? Can we resuscitate Melloware's PR and wrap up this issue? > > Thanks, > > Josh. > > > > -----Original Message----- > > From: Gary Gregory <garydgreg...@gmail.com> > > Sent: Monday, September 16, 2024 4:26 PM > > To: Commons Developers List <dev@commons.apache.org> > > Subject: Re: [beanutils] For 2.0, WeakFastHashMap vs ConcurrentHashMap > > > > > > CAUTION: This email originated from outside the organization. Do not click > > links or open attachments unless you recognize the sender and know the > > content is safe. If you believe this is a phishing email, use the Report to > > Cybersecurity icon in Outlook. > > > > > > > > Which points to: > > https://issu/ > > es.apache.org%2Fjira%2Fbrowse%2FBEANUTILS-509&data=05%7C02%7CJosh.Fenl > > ason%40veritas.com%7C594b7769bda54bbd892d08dcdd9ba40c%7Cfc8e13c0422c4c > > 55b3eaca318e6cac32%7C0%7C0%7C638628907749754165%7CUnknown%7CTWFpbGZsb3 > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > C0%7C%7C%7C&sdata=SGR%2B0SfgS%2F7gmd8VCPOlTmmlwQQNNp77J05QI5fFaBc%3D&r > > eserved=0 > > > > Gary > > > > On Mon, Sep 16, 2024, 5:24 PM Gary Gregory <garydgreg...@gmail.com> wrote: > > > > > Related: > > > https://issu/ > > > es.apache.org%2Fjira%2Fbrowse%2FCOLLECTIONS-700&data=05%7C02%7CJosh. > > > Fe > > > nlason%40veritas.com%7Ca17c9a6a13a540debe7f08dcd6963dfb%7Cfc8e13c042 > > > 2c > > > 4c55b3eaca318e6cac32%7C0%7C0%7C638621188049710140%7CUnknown%7CTWFpbG > > > Zs > > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > > 3D > > > %7C0%7C%7C%7C&sdata=UspxFjiRSi4rTJSW7wNHs2XESjZ0Cvbm350jrmVMD3I%3D&r > > > es > > > erved=0 > > > > > > Gary > > > > > > On Sat, Sep 14, 2024, 10:16 AM Xeno Amess <xenoam...@gmail.com> wrote: > > > > > >> IMO I think it ok...so Gary which part do you feel unsafe in it ?I > > >> must admit I am not that familiar to lawyer things.. > > >> ________________________________ > > >> From: Melloware Inc <melloware...@gmail.com> > > >> Sent: Saturday, September 14, 2024 9:18:08 PM > > >> To: Commons Developers List <dev@commons.apache.org> > > >> Subject: Re: [beanutils] For 2.0, WeakFastHashMap vs > > >> ConcurrentHashMap > > >> > > >> Well in my PR the license in the file says this. > > >> > > >> Written by Doug Lea with assistance from members of JCP JSR-166 > > >> Expert Group and released to the public domain, as explained at > > >> @see <a > > >> href="https://nam12.safelinks.protection.outlook.com/?url=http%3A%252 > > >> F%25 > > >> 2Fcreativecommons.org%2Flicenses%2Fpublicdomain&data=05%7C02%7CJosh > > >> .F > > >> enlason%40veritas.com%7Ca17c9a6a13a540debe7f08dcd6963dfb%7Cfc8e13c0 > > >> 42 > > >> 2c4c55b3eaca318e6cac32%7C0%7C0%7C638621188049723177%7CUnknown%7CTWF > > >> pb > > >> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > > >> Mn > > >> 0%3D%7C0%7C%7C%7C&sdata=Vgo5BT3zXWMHgn4iv1PKrw0kZd2JMUo2V1o78%2FMuF > > >> po > > >> %3D&reserved=0">Creative > > >> Commons</a> > > >> > > >> it says its public domain. > > >> > > >> On Sat, Sep 14, 2024 at 9:01 AM Xeno Amess <xenoam...@gmail.com> wrote: > > >> > > >> > why not write an email to lea ..maybe he be so kind that would be > > >> > glad > > >> to > > >> > offer one mit-like license copy of that class > > >> > ________________________________ > > >> > From: Melloware Inc <melloware...@gmail.com> > > >> > Sent: Saturday, September 14, 2024 8:32:38 PM > > >> > To: Commons Developers List <dev@commons.apache.org> > > >> > Subject: Re: [beanutils] For 2.0, WeakFastHashMap vs > > >> > ConcurrentHashMap > > >> > > > >> > I submitted this PR years ago using ConcurrentWeakKeyHashMap from > > >> > Doug > > >> Lea > > >> > and the Netty team but Gary had concerns from legal about being > > >> > able to > > >> use > > >> > it. > > >> > > > >> > PR is here: > > >> > https://g/ > > >> > ithub.com%2Fapache%2Fcommons-beanutils%2Fpull%2F56&data=05%7C02%7 > > >> > CJ > > >> > osh.Fenlason%40veritas.com%7Ca17c9a6a13a540debe7f08dcd6963dfb%7Cf > > >> > c8 > > >> > e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638621188049734927%7CUnkn > > >> > ow > > >> > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > > >> > Ww > > >> > iLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=ERcuJKHJW%2F7plLn9Pj5nUaA4rFCu > > >> > kB > > >> > s8V6WP%2BABCzRc%3D&reserved=0 > > >> > > > >> > On Sat, Sep 14, 2024 at 7:22 AM Xeno Amess <xenoam...@gmail.com> wrote: > > >> > > > >> > > I thought old d-lea bro have a concurrent weak hashmap > > >> > > implement somewhere...why not just ask him after all nobody > > >> > > here more expert than him in this area > > >> > > ________________________________ > > >> > > From: Niall Pemberton <niall.pember...@gmail.com> > > >> > > Sent: Saturday, September 14, 2024 1:46:32 PM > > >> > > To: Commons Developers List <dev@commons.apache.org> > > >> > > Subject: Re: [beanutils] For 2.0, WeakFastHashMap vs > > >> > > ConcurrentHashMap > > >> > > > > >> > > On Thu, 12 Sep 2024 at 19:59, Gary D. Gregory > > >> > > <ggreg...@apache.org> > > >> > wrote: > > >> > > > > >> > > > Hi All, > > >> > > > > > >> > > > For the upcoming 2.0.0-M1, I plan on replacing the custom > > >> > WeakFastHashMap > > >> > > > with the stock ConcurrentHashMap. > > >> > > > > > >> > > > If you think this is a bad idea, please tell us why. > > >> > > > > >> > > > > >> > > It’s a good idea for the “fast” part, but the “weak” aspect > > >> > > also > > >> needs to > > >> > > be retained - so in principle yes, but the implementation > > >> > > detail > > >> matters. > > >> > > > > >> > > BeanUtils caused memory issues in multiple ClassLoader > > >> > > environments > > >> (e.g. > > >> > > WebApp containers) because of strong references to classes > > >> > > prevented > > >> them > > >> > > from being garbage collected if the app was reloaded/restarted. > > >> > > So > > >> this > > >> > > weak map was introduced to resolve that issue. > > >> > > > > >> > > Niall > > >> > > > > >> > > > > >> > > > > > >> > > > Gary > > >> > > > > > >> > > > > > >> ------------------------------------------------------------------- > > >> -- > > >> > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > >> > > > For additional commands, e-mail: dev-h...@commons.apache.org > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > -- > > >> > ============================== > > >> > Melloware > > >> > melloware...@gmail.com > > >> > http://me/ > > >> > lloware.com%2F&data=05%7C02%7CJosh.Fenlason%40veritas.com%7Ca17c9 > > >> > a6 > > >> > a13a540debe7f08dcd6963dfb%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0% > > >> > 7C > > >> > 0%7C638621188049744703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD > > >> > Ai > > >> > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata > > >> > =o > > >> > 6%2BhNto8to7f4E1GZtN%2BpFVpoFx0b4gI4Exy90G7apk%3D&reserved=0 > > >> > ============================== > > >> > > > >> > > >> > > >> -- > > >> ============================== > > >> Melloware > > >> melloware...@gmail.com > > >> http://mell/ > > >> oware.com%2F&data=05%7C02%7CJosh.Fenlason%40veritas.com%7Ca17c9a6a1 > > >> 3a > > >> 540debe7f08dcd6963dfb%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C > > >> 63 > > >> 8621188049751739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > > >> oi > > >> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Iof1UJppc > > >> Gh > > >> PV%2F5T2Lmo5i%2BX1nA%2F0V1M7eyEqjvHtUQ%3D&reserved=0 > > >> ============================== > > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org