Hi Emmanuel,

On 12.11.2025 10:57, Emmanuel Bourg wrote:
> On 12/11/2025 08:38, Piotr P. Karwasz wrote:
>> They only prevent deletion and force pushes on the `master` branch.
> 
> +1 to preventing master branch deletion.
> 
> -0 to preventing force pushes. We all know it's bad and we should avoid
> it, but it may be useful in rare occasions. I wouldn't take away that
> tool unless it's abused.


I don't think there rules can be enabled separately. Looking at the
`.asf.yaml` implementation [1], force pushes are disabled explicitly in
the code (`allow_force_pushes = False`), while `allow_deletions` is not
handled by the code at all and retains its `False` value.


>> This configuration enables GitHub’s *auto-merge* feature, allowing PRs
>> to be merged automatically once all required CI checks succeed.
> 
> -0, PRs may become unmergeable due to an unrelated temporary CI issue.
> I'd leave that to the dev appreciation.


The “auto-merge“ feature can only be enabled only if there is at least
one condition to merge the PR. It can even be a single workflow or CodeQL.

Piotr

[1]
https://github.com/apache/infrastructure-asfyaml/blob/main/asfyaml/feature/github/branch_protection.py


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to