Please can I have another review. Thank you. Alex
On Thu, 30 Apr 2026 at 09:26, Alex Herbert <[email protected]> wrote: > My +1. > > Please can I have another review. Thank you. > > Alex > > > On Tue, 28 Apr 2026 at 19:13, Gary Gregory <[email protected]> wrote: > >> You can also use -P jacoco >> >> On Tue, Apr 28, 2026, 12:54 sebb <[email protected]> wrote: >> >> > On Tue, 28 Apr 2026 at 17:14, Alex Herbert <[email protected]> >> > wrote: >> > > >> > > On Tue, 28 Apr 2026 at 16:40, Gilles Sadowski <[email protected]> >> > wrote: >> > > >> > > > Hi. >> > > > >> > > > Le lun. 27 avr. 2026 à 14:21, Alex Herbert < >> [email protected]> >> > a >> > > > écrit : >> > > > > >> > > > > We have fixed quite a few bugs and added some significant >> > enhancements >> > > > > since Apache Commons Statistics 1.2 was released, >> > > > > so I would like to release Apache Commons Statistics 1.3. >> > > > > >> > > > > Apache Commons Statistics 1.3 RC1 is available for review here: >> > > > > >> > https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1 >> > > > (svn >> > > > > revision 84131) >> > > > > >> > > > > The Git tag commons-statistics-1.3-RC1 commit for this RC is >> > > > > commons-statistics-1.3-RC1, which you can browse here: >> > > > > >> > > > > >> > > > >> > >> https://gitbox.apache.org/repos/asf?p=commons-statistics.git;a=commit;h=commons-statistics-1.3-RC1 >> > > > > >> > > > > You may checkout this tag using: >> > > > > git clone >> > https://gitbox.apache.org/repos/asf/commons-statistics.git >> > > > --branch commons-statistics-1.3-RC1 commons-statistics-1.3-RC1 >> > > > >> > > > Commands >> > > > $ mvn >> > > > $ mvn mvn clean install site site:stage -Pexamples >> > > > were both successful on >> > > > $ mvn --version >> > > > Apache Maven 3.9.9 >> > > > Maven home: /usr/share/maven >> > > > Java version: 21.0.10, vendor: Debian, runtime: >> > > > /usr/lib/jvm/java-21-openjdk-amd64 >> > > > Default locale: en_US, platform encoding: UTF-8 >> > > > OS name: "linux", version: "6.12.73+deb13-amd64", arch: "amd64", >> > family: >> > > > "unix" >> > > > >> > > > > Maven artifacts are here: >> > > > > >> > > > > >> > > > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1933/org/apache/commons/ >> > > > >> > > > Output of "signature-validator.sh" script downloaded from >> > > > the SVN repository mentioned above: >> > > > ---CUT--- >> > > > INFO: Downloading artifacts from nexus >> > > > >> > > > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1933/org/apache/commons/ >> > > > INFO: Validating Signatures in >> > > > >> > > > >> > >> /home/gilles/gilles/devel/java/apache/release_check/statistics/1.3-RC1/artifacts-for-validation-deletable-post-validation >> > > > SUCCESSFUL VALIDATION >> > > > ---CUT--- >> > > > >> > > > > [...] >> > > > >> JApiCmp Report: >> > > > > >> > > > > >> > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1/site/commons-statistics-descriptive/japicmp.html >> > > > > >> > > > > >> > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1/site/commons-statistics-distribution/japicmp.html >> > > > > >> > > > > >> > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1/site/commons-statistics-inference/japicmp.html >> > > > > >> > > > > >> > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1/site/commons-statistics-interval/japicmp.html >> > > > > >> > > > > >> > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/statistics/1.3-RC1/site/commons-statistics-ranking/japicmp.html >> > > > >> > > > OK. >> > > > [Does the build fail when "japicmp" (or "revapi") detects >> something?] >> > > > >> > > >> > > Yes. >> > > >> > > This repo only uses japicmp. It will fail if there is an incompatible >> > > change. For example a refactor of an enum name in the ranking module >> > caused >> > > the local build to fail. >> > > >> > > This release has new methods added in descriptive and distribution >> that >> > > show in the report. But no incompatible changes. The other reports are >> > > empty as there are no changes to the modules. >> > > >> > > Note: There is no configuration for japicmp in the poms, other than to >> > > disable breaking the build in the docs and examples modules. All the >> > > configuration is from commons-parent and it is activated by the files: >> > > >> > > ./commons-statistics-interval/src/site/resources/profile.japicmp >> > > ./commons-statistics-inference/src/site/resources/profile.japicmp >> > > ./commons-statistics-descriptive/src/site/resources/profile.japicmp >> > > ./commons-statistics-distribution/src/site/resources/profile.japicmp >> > > ./commons-statistics-ranking/src/site/resources/profile.japicmp >> > > >> > > When cutting RC1 I noticed the profile missing from the interval >> module >> > > which was new in the last release (1.2). I think all released modules >> now >> > > have the profile. >> > > >> > > This setup is subject to user error if the profiles are missing. >> However >> > a >> > > quick test shows that japicmp will gracefully ignore a missing binary >> > > compatibility file. So it should be OK to add this file when a new >> module >> > > is created, and not leave it until after release. Unfortunately a >> quick >> > > test shows that the profile cannot be placed in the parent pom to >> apply >> > to >> > > all child modules; the maven profile activation is made on a >> per-module >> > > basis. >> > > >> > > If missing the profile activation files you can still manually >> activate >> > the >> > > profile. This command works from the top level and runs japicmp in all >> > > modules even when I delete the profile files. >> > > >> > > mvn package -DskipTests -P japicmp japicmp:cmp >> > >> > According to the parent pom where the japicmp profile is defined, it >> > is activated for Java 1.8+ and also if the following file exists: >> > >> > src/site/resources/profile.japicmp >> > >> > So creating that file should do what you want. >> > >> > > Alex >> > > >> > > >> > > > > [...] >> > > > >> > > > [X] +1 Release these artifacts >> > > > > [ ] +0 OK, but... >> > > > > [ ] -0 OK, but really should fix... >> > > > > [ ] -1 I oppose this release because... >> > > > > >> > > > >> > > > Thanks, >> > > > Gilles >> > > > >> > > > > [...] >> > > > >> > > > >> --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: [email protected] >> > > > For additional commands, e-mail: [email protected] >> > > > >> > > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > >> >
