[
https://issues.apache.org/jira/browse/COMMONSRDF-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532935#comment-15532935
]
ASF GitHub Bot commented on COMMONSRDF-33:
------------------------------------------
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/23#discussion_r81149695
--- Diff: jena/src/main/java/org/apache/commons/rdf/jena/JenaQuadLike.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.rdf.jena;
+
+import org.apache.commons.rdf.api.QuadLike;
+import org.apache.commons.rdf.api.RDFTerm;
+import org.apache.jena.sparql.core.Quad;
+
+/** Access the Jena quad backing this object */
+public interface JenaQuadLike<S extends RDFTerm, P extends RDFTerm, O
extends RDFTerm, G extends RDFTerm>
--- End diff --
Yes, but perhaps there should be a subtype `JenaGeneralizedQuadLike`? I
was reluctant to imply it was a `Quad` subtype, as I think it should not have
the `Quad.equals()` logic.
Now
[fromJenaGeneralized()](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/jena/JenaRDFTermFactory.html#fromJenaGeneralized-org.apache.jena.sparql.core.Quad-)
returns a ```JenaQuadLike<RDFTerm,RDFTerm,RDFTerm,RDFTerm>```
I see now that I have
[createGeneralizedTriple()](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/jena/JenaRDFTermFactory.html#createGeneralizedTriple-org.apache.commons.rdf.api.RDFTerm-org.apache.commons.rdf.api.RDFTerm-org.apache.commons.rdf.api.RDFTerm-)
but forgot `createGeneralizedQuad()` - obviously both should be there.
> Jena integration
> ----------------
>
> Key: COMMONSRDF-33
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-33
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Fix For: 0.3.0
>
>
> Add a new jena/ module with implementations mapping to Jena 3.x
> Based on JENA-1015, https://github.com/afs/commonsrdf-jena and
> https://github.com/stain/incubator-commonsrdf/tree/jena
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
