Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/24#discussion_r81655494
--- Diff:
rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF4JGraphLike.java ---
@@ -0,0 +1,63 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rdf.rdf4j;
+
+import java.util.Optional;
+
+import org.apache.commons.rdf.api.BlankNodeOrIRI;
+import org.apache.commons.rdf.api.GraphLike;
+import org.apache.commons.rdf.api.IRI;
+import org.apache.commons.rdf.api.RDFTerm;
+import org.apache.commons.rdf.api.TripleLike;
+import org.eclipse.rdf4j.model.Model;
+import org.eclipse.rdf4j.repository.Repository;
+
+/**
+ * Marker interface for RDF4J implementations of GraphLike.
+ *
+ * @see RDF4JGraph
+ *
+ */
+public interface RDF4JGraphLike<T extends TripleLike<BlankNodeOrIRI, IRI,
RDFTerm>>
--- End diff --
Rather than naming those interfaces "TripleLike", it may be more useful to
be upfront that Commons RDF is based on Generalised RDF by naming them
GeneralisedTriple or similar. Ie, to support Jena as a lowest common
denominator, the basic entity isn't an RDF-1.1 Triple but a Generalised Triple
(assuming that means `<RDFTerm, RDFTerm, RDFTerm>` for the three positions but
not familiar with Jena so not sure if the predicate is restricted to
`BlankNodeOrIRI` or `IRI`).
One issue with potential uptake of Commons RDF in the community would be to
make sure that users could structure their code to avoid the generics arguments
that are unnecessary in almost all cases. Ie, if users know that their code
cannot accept or deal with Generalised RDF, they should have a simple way of
saying that in their APIs, leaving any conversion/reification to the small
percentage of users who need Generalised RDF.
I am not yet clear on why `Triple` cannot inherit from
`TripleLike<BlankNodeOrIRI, IRI, RDFTerm>`. Ie, I don't see why another
heirarchy, for `RDFTripleLike`, needs to be created for the typical RDF user to
work through rather than just subinterfacing Triple onto GeneralisedTriple with
a different set of generics arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
