[
https://issues.apache.org/jira/browse/COMMONSRDF-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553686#comment-15553686
]
ASF GitHub Bot commented on COMMONSRDF-35:
------------------------------------------
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/24#discussion_r82312585
--- Diff:
rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/ModelGraphImpl.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rdf.rdf4j.impl;
+
+import java.util.Collections;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import org.apache.commons.rdf.api.BlankNodeOrIRI;
+import org.apache.commons.rdf.api.RDFTerm;
+import org.apache.commons.rdf.api.Triple;
+import org.apache.commons.rdf.rdf4j.RDF4JBlankNodeOrIRI;
+import org.apache.commons.rdf.rdf4j.RDF4JGraph;
+import org.apache.commons.rdf.rdf4j.RDF4JTermFactory;
+import org.apache.commons.rdf.rdf4j.RDF4JTriple;
+import org.eclipse.rdf4j.model.Model;
+import org.eclipse.rdf4j.model.Resource;
+import org.eclipse.rdf4j.repository.Repository;
+
+public final class ModelGraphImpl implements RDF4JGraph {
+
+ private Model model;
+ private RDF4JTermFactory rdf4jTermFactory;
+
+ public ModelGraphImpl(Model model) {
+ this.model = model;
+ this.rdf4jTermFactory = new RDF4JTermFactory();
+ }
+
+ public ModelGraphImpl(Model model, RDF4JTermFactory rdf4jTermFactory) {
+ this.model = model;
+ this.rdf4jTermFactory = rdf4jTermFactory;
+ }
+
+ @Override
+ public void add(BlankNodeOrIRI subject, org.apache.commons.rdf.api.IRI
predicate, RDFTerm object) {
+ model.add(
+ (Resource)rdf4jTermFactory.asValue(subject),
+
(org.eclipse.rdf4j.model.IRI)rdf4jTermFactory.asValue(predicate),
+ rdf4jTermFactory.asValue(object));
+ }
+
+ @Override
+ public void add(Triple triple) {
+ model.add(rdf4jTermFactory.asStatement(triple));
+ }
+
+ public Optional<Model> asModel() {
+ return Optional.of(model);
+ }
+
+ @Override
+ public Optional<Repository> asRepository() {
+ return Optional.empty();
+ }
+
+ @Override
+ public void clear() {
+ model.clear();
+ }
+
+ @Override
+ public boolean contains(BlankNodeOrIRI subject,
org.apache.commons.rdf.api.IRI predicate, RDFTerm object) {
+ return model.contains(
+ (Resource)rdf4jTermFactory.asValue(subject),
+
(org.eclipse.rdf4j.model.IRI)rdf4jTermFactory.asValue(predicate),
+ rdf4jTermFactory.asValue(object));
+ }
+
+ @Override
+ public boolean contains(Triple triple) {
+ return model.contains(rdf4jTermFactory.asStatement(triple));
+ }
+
+ @Override
+ public void remove(BlankNodeOrIRI subject,
org.apache.commons.rdf.api.IRI predicate, RDFTerm object) {
+ model.remove(
+ (Resource)rdf4jTermFactory.asValue(subject),
+
(org.eclipse.rdf4j.model.IRI)rdf4jTermFactory.asValue(predicate),
+ rdf4jTermFactory.asValue(object));
+ }
+
+ @Override
+ public void remove(Triple triple) {
+ model.remove(rdf4jTermFactory.asStatement(triple));
+ }
+
+ @Override
+ public long size() {
+ int size = model.size();
+ if (size < Integer.MAX_VALUE) {
+ return size;
+ } else {
+ // TODO: Check if this can really happen with RDF4J
models
+ // Collection.size() can't help us, we'll have to count
+ return model.parallelStream().count();
+ }
+ }
+
+ @Override
+ public Stream<RDF4JTriple> stream() {
+ return model.parallelStream().map(rdf4jTermFactory::asTriple);
+ }
+
+ @Override
+ public Stream<RDF4JTriple> stream(BlankNodeOrIRI subject,
org.apache.commons.rdf.api.IRI predicate, RDFTerm object) {
+ return model.filter(
+ (Resource)rdf4jTermFactory.asValue(subject),
+
(org.eclipse.rdf4j.model.IRI)rdf4jTermFactory.asValue(predicate),
+
rdf4jTermFactory.asValue(object)).parallelStream()
+ .map(rdf4jTermFactory::asTriple);
+ }
+
+ @Override
+ public Set<RDF4JBlankNodeOrIRI<Resource>> getContextMask() {
+ // ModelGraph always do the unionGraph
+ return Collections.emptySet();
+ // TODO: Should we support contextMask like in
RepositoryGraphImpl?
--- End diff --
OK, I'll track that in Jira. Probably a similar `AbstractModelGraphLike`
can be shared between `ModelGraphImpl` and `RepositoryGraphImpl`.
Why do RDF4J have these two slightly different APIs..? Are both commonly
used? I know there was talk of an adapter being contributed from Clerezza.
> rdf4j integration
> -----------------
>
> Key: COMMONSRDF-35
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-35
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Labels: integration, rdf4j, sesame
> Fix For: 0.3.0
>
>
> Add a new rdf4j module with implementation for Eclipse rdf4j
> See https://github.com/apache/incubator-commonsrdf/tree/rdf4j/rdf4j
> A legacy sesame branch could then be added by mainly copy/paste and change
> the import
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
