I added tests for the Default implementations in API, as well as AbstractDatasetTest and its children in simple/jena/rdf4j/jsonld.
I'm afraid this highlighted several bugs in each of the Quad/Dataset implementations which I have since fixed - so I'll CANCEL this vote. For details, see https://github.com/apache/incubator-commonsrdf/compare/0.3.0-incubating-RC1...3ba5c3b9316b3d3 I'll then try again with a 0.3.0 RC2 :) On 3 November 2016 at 11:11, Stian Soiland-Reyes <st...@apache.org> wrote: > Agree, we should aim for ~ full coverage for 1.0, at least for the simple > module. > > This proposed version adds new classes like DatasetImpl which don't have > tests yet (however they should be pretty similar to the existing Graph > tests). > > > On 2 Nov 2016 3:12 pm, "Gary Gregory" <garydgreg...@gmail.com> wrote: >> >> Build warnings that we are breaking our own rules: >> >> [INFO] --- jacoco-maven-plugin:0.7.6.201602180812:check (check) @ >> commons-rdf-simple --- >> [INFO] Analyzed bundle 'Commons RDF: Simple Implementation' with 13 >> classes >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: >> classes >> covered ratio is 0.69, but expected minimum is 1.00 >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: >> instructions covered ratio is 0.61, but expected minimum is 0.90 >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: >> methods >> covered ratio is 0.61, but expected minimum is 0.95 >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: >> branches covered ratio is 0.48, but expected minimum is 0.85 >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: lines >> covered ratio is 0.65, but expected minimum is 0.90 >> [WARN] Rule violated for bundle Commons RDF: Simple Implementation: >> complexity covered ratio is 0.52, but expected minimum is 0.85 >> [WARN] Coverage checks have not been met. See log for details. >> >> IMO, coverage should be as close to 100% for 1.0. So might as well get >> cooking now... ASAP ;-) >> >> Gary >> >> On Sun, Oct 30, 2016 at 3:00 PM, Stian Soiland-Reyes <st...@apache.org> >> wrote: >> >> > I am pleased to be calling this vote for the release of >> > >> > >> > Apache Commons RDF 0.3.0-incubating >> > >> > >> > Apache Commons RDF aims to provide a common Java API for RDF 1.1 >> > graphs and datasets. API bindings in Commons RDF 0.3.0 include Apache >> > Jena, Eclipse RDF4J, JSON-LD Java as well as a standalone >> > implementation. >> > >> > >> > The release candidate to be voted over is available at: >> > >> > https://dist.apache.org/repos/dist/dev/incubator/commonsrdf/ >> > 0.3.0-incubating-RC1/ >> > >> > >> > sha1 checksums: >> > >> > 6e9cd740b7d3bff0ae1174edddc0effdc346809e >> > apache-commons-rdf-0.3.0-incubating-src.tar.gz >> > aca3bafcfc6e87213aa0497af072b66a1f3d27b6 >> > apache-commons-rdf-0.3.0-incubating-src.zip >> > >> > md5 checksums: >> > >> > 6dec30045d37f6912fcb768ac3c3703c apache-commons-rdf-0.3.0- >> > incubating-src.tar.gz >> > 864119895c9d3e619f96b314d82ca7b1 apache-commons-rdf-0.3.0- >> > incubating-src.zip >> > >> > >> > >> > To build the release candidate (requires JDK 8, Maven 3.3), run: >> > >> > mvn clean verify >> > >> > To rebuild the site, use: >> > >> > mvn package site >> > >> > >> > git commit: >> > d3f22c605eafd6fbdc4e485c8fe0607334a1bb94 >> > https://git-wip-us.apache.org/repos/asf?p=incubator- >> > commonsrdf.git;a=tag;h=refs/tags/0.3.0-incubating-RC1 >> > >> > >> > KEYS: >> > https://dist.apache.org/repos/dist/release/incubator/commonsrdf/KEYS >> > >> > >> > Maven staging repository: >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1217/ >> > >> > >> > Release notes: >> > https://github.com/apache/incubator-commonsrdf/blob/ >> > master/RELEASE-NOTES.txt >> > >> > >> > Site: >> > http://stain.github.io/incubator-commonsrdf/0.3.0-rc1/ >> > >> > >> > Tip: Project reports are more useful per module, e.g. >> > http://stain.github.io/incubator-commonsrdf/0.3.0- >> > rc1/commons-rdf-api/japicmp.html >> > http://stain.github.io/incubator-commonsrdf/0.3.0-rc1/commons-rdf-rdf4j/ >> > dependencies.html >> > >> > >> > Javadoc: >> > http://stain.github.io/incubator-commonsrdf/0.3.0-rc1/apidocs/ >> > >> > >> > >> > Please vote on releasing this release candidate as: >> > >> > Apache Commons RDF 0.3.0-incubating >> > >> > >> > >> > The vote is open for at least 72 hours, let's say 2016-11-03 12:00 UTC. >> > >> > >> > [ ] +1 Release this package >> > [ ] 0 I don't feel strongly about it, but don't object >> > [ ] -1 Do not release this package because... >> > >> > >> > Anyone can participate in testing and voting, not just committers, >> > please feel free to try out the release candidate and provide your >> > votes! >> > >> > >> > -- >> > Stian Soiland-Reyes >> > http://orcid.org/0000-0001-9842-9718 >> > >> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> >> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> >> >> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> >> JUnit in Action, Second Edition >> >> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> >> >> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> >> Spring Batch in Action >> >> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> >> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory -- Stian Soiland-Reyes http://orcid.org/0000-0001-9842-9718
