I think given the confusing nature of how the code reads it needs
significant comments and a unit test then... if I encountered this
later I'd assume it's a mistake and change it.
On 03/06/2009, at 8:20 PM, Jevica Arianne B. Zurbano wrote:
The current behavior, having "ERROR" being returned will redirect to
the Error page with no error message and no stack trace.
And, the action error is displayed in another page; the page that is
being accessed after the Error Occured page is displayed.
The fix is to have the action error displayed in the build
environment list page (success page).
Brett Porter wrote:
I don't understand how this is the correct fix. Won't an exception
now go to the success page and not produce an error?
On 03/06/2009, at 6:47 PM, [email protected] wrote:
Author: jzurbano
Date: Wed Jun 3 08:47:02 2009
New Revision: 781301
URL: http://svn.apache.org/viewvc?rev=781301&view=rev
Log:
[CONTINUUM-2250] Build Environment error message is displayed on
the first accessed page
Modified:
continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/
org/apache/maven/continuum/web/action/admin/ProfileAction.java
Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/
main/java/org/apache/maven/continuum/web/action/admin/
ProfileAction.java
URL:
http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java?rev=781301&r1=781300&r2=781301&view=diff
=
=
=
=
=
=
=
=
=
=
====================================================================
--- continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
java/org/apache/maven/continuum/web/action/admin/
ProfileAction.java (original)
+++ continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
java/org/apache/maven/continuum/web/action/admin/
ProfileAction.java Wed Jun 3 08:47:02 2009
@@ -183,7 +183,6 @@
catch ( ProfileException e )
{
addActionError( getText( "profile.remove.error" ) );
- return ERROR;
}
return SUCCESS;
}
--
Thanks,
Jev
