Code cleaned up, here is the pull request:

https://github.com/apache/incubator-cordova-js/pull/39

Markus

-----Original Message-----
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Mittwoch, 24. Oktober 2012 22:41
To: callback-...@incubator.apache.org
Subject: Re: 2.2.0rc2 Monday?

Thanks Simon. There is a lot of jshint issues for windows8 and webos.
Are these known issues?:

files with whitespace issues: (to fix: `jake fixwhitespace`)
   lib/windows8/plugin/windows8/FileProxy.js
lib/ios/exec.js: line 166, col 30, Use '===' to compare with '0'.
lib/tizen/plugin/tizen/ContactUtils.js: line 70, col 40, 
'initializeAllFieldsMapping' is already defined.
lib/webos/platform.js: line 31, col 10, Missing semicolon.
lib/webos/platform.js: line 28, col 9, 'Mojo' is not defined.
lib/webos/platform.js: line 29, col 9, 'Mojo' is not defined.
lib/webos/plugin/webos/accelerometer.js: line 46, col 6, Missing semicolon.
lib/webos/plugin/webos/accelerometer.js: line 54, col 2, Missing semicolon.
lib/webos/plugin/webos/accelerometer.js: line 44, col 25, 'Acceleration' is not 
defined.
lib/webos/plugin/webos/application.js: line 27, col 47, Missing semicolon.
lib/webos/plugin/webos/application.js: line 72, col 2, Missing semicolon.
lib/webos/plugin/webos/application.js: line 62, col 12, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/application.js: line 68, col 16, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/camera.js: line 50, col 2, Missing semicolon.
lib/webos/plugin/webos/compass.js: line 37, col 14, Missing semicolon.
lib/webos/plugin/webos/compass.js: line 41, col 2, Missing semicolon.
lib/webos/plugin/webos/compass.js: line 28, col 13, 'device' is not defined.
lib/webos/plugin/webos/compass.js: line 28, col 41, 'device' is not defined.
lib/webos/plugin/webos/device.js: line 22, col 52, Missing semicolon.
lib/webos/plugin/webos/device.js: line 38, col 37, 'PalmSystem' is not defined.
lib/webos/plugin/webos/filereader.js: line 71, col 55, Use '!==' to compare 
with 'null'.
lib/webos/plugin/webos/keyboard.js: line 55, col 13, Duplicate member 
'isManualMode'.
lib/webos/plugin/webos/keyboard.js: line 67, col 2, Missing semicolon.
lib/webos/plugin/webos/keyboard.js: line 39, col 12, '_isShowing' is not 
defined.
lib/webos/plugin/webos/keyboard.js: line 42, col 8, 'isManualMode' is not 
defined.
lib/webos/plugin/webos/keyboard.js: line 43, col 9, 'PalmSystem' is not defined.
lib/webos/plugin/webos/keyboard.js: line 47, col 8, 'isManualMode' is not 
defined.
lib/webos/plugin/webos/keyboard.js: line 48, col 9, 'PalmSystem' is not defined.
lib/webos/plugin/webos/keyboard.js: line 52, col 5, '_manual' is not defined.
lib/webos/plugin/webos/keyboard.js: line 53, col 5, 'PalmSystem' is not defined.
lib/webos/plugin/webos/keyboard.js: line 56, col 12, '_manual' is not defined.
lib/webos/plugin/webos/keyboard.js: line 60, col 5, 'PalmSystem' is not defined.
lib/webos/plugin/webos/keyboard.js: line 64, col 5, 'PalmSystem' is not defined.
lib/webos/plugin/webos/network.js: line 22, col 52, Missing semicolon.
lib/webos/plugin/webos/notification.js: line 49, col 18, 'response' is already 
defined.
lib/webos/plugin/webos/notification.js: line 132, col 15, 'a' is already 
defined.
lib/webos/plugin/webos/notification.js: line 175, col 2, Missing semicolon.
lib/webos/plugin/webos/notification.js: line 52, col 5, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/notification.js: line 67, col 13, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/notification.js: line 78, col 5, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/notification.js: line 107, col 5, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/notification.js: line 118, col 5, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/notification.js: line 142, col 9, 'w' is not defined.
lib/webos/plugin/webos/notification.js: line 143, col 16, 'w' is not defined.
lib/webos/plugin/webos/notification.js: line 172, col 40, 'icon' is not defined.
lib/webos/plugin/webos/orientation.js: line 36, col 2, Missing semicolon.
lib/webos/plugin/webos/orientation.js: line 25, col 5, 'PalmSystem' is not 
defined.
lib/webos/plugin/webos/orientation.js: line 33, col 14, 'PalmSystem'
is not defined.
lib/webos/plugin/webos/requestfilesystem.js: line 35, col 6, Missing semicolon.
lib/webos/plugin/webos/service.js: line 24, col 2, Unnecessary semicolon.
lib/webos/plugin/webos/service.js: line 71, col 2, Missing semicolon.
lib/webos/plugin/webos/service.js: line 27, col 19, 'PalmServiceBridge' is not 
defined.
lib/webos/plugin/webos/window.js: line 91, col 2, Missing semicolon.
lib/webos/plugin/webos/window.js: line 25, col 23, 'PalmSystem' is not defined.
lib/webos/plugin/webos/window.js: line 50, col 5, 'PalmSystem' is not defined.
lib/webworks/qnx/plugin/qnx/capture.js: line 30, col 9, 
'webkitRequestFileSystem' is not defined.
lib/webworks/qnx/plugin/qnx/capture.js: line 30, col 33, 'PERSISTENT'
is not defined.
lib/windows8/platform.js: line 52, col 14, Unnecessary semicolon.
lib/windows8/plugin/windows8/CameraProxy.js: line 194, col 22, 'fail'
is already defined.
lib/windows8/plugin/windows8/FileProxy.js: line 197, col 47, Bad escapement.
lib/windows8/plugin/windows8/FileProxy.js: line 279, col 50, Trailing 
whitespace.
lib/windows8/plugin/windows8/FileProxy.js: line 326, col 67, Trailing 
whitespace.
lib/windows8/plugin/windows8/FileProxy.js: line 352, col 37, Unnecessary 
semicolon.
lib/windows8/plugin/windows8/FileProxy.js: line 377, col 47, Bad escapement.
lib/windows8/plugin/windows8/FileProxy.js: line 803, col 39, Bad escapement.
lib/windows8/plugin/windows8/FileProxy.js: line 807, col 41, Bad escapement.
lib/windows8/plugin/windows8/geolocation.js: line 36, col 13, 'options' is not 
defined.
lib/windows8/plugin/windows8/geolocation.js: line 40, col 40, 'options' is not 
defined.
lib/windows8/plugin/windows8/geolocation.js: line 40, col 60, 'options' is not 
defined.
lib/windows8/plugin/windows8/geolocation.js: line 107, col 9, 'timers'
is not defined.
lib/windows8/plugin/windows8/geolocation.js: line 107, col 16, 'id' is not 
defined.
lib/windows8/plugin/windows8/geolocation.js: line 107, col 87, 'options' is not 
defined.
lib/windows8/plugin/windows8/geolocation.js: line 107, col 107, 'options' is 
not defined.
lib/windows8/plugin/windows8/geolocation.js: line 108, col 17, 'Geolocation' is 
not defined.
lib/windows8/plugin/windows8/geolocation.js: line 108, col 61, 'options' is not 
defined.
lib/windows8/plugin/windows8/MediaFile.js: line 32, col 44, 'contentType' is 
not defined.

On Wed, Oct 24, 2012 at 1:33 PM, Simon MacDonald <simon.macdon...@gmail.com> 
wrote:
> Okay JS and Android re-tagged to 2.2.0 cause of soem Android 2.2 craziness.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Wed, Oct 24, 2012 at 4:24 PM, Simon MacDonald
> <simon.macdon...@gmail.com>wrote:
>
>> I have to re-tag JS and Android. There is a bug that causes almost 
>> everything to fail on Android 2.2. The code is in the Android version 
>> of exec so other platforms will not need to pick up the new JS.
>>
>> Simon Mac Donald
>> http://hi.im/simonmacdonald
>>
>>
>> On Wed, Oct 24, 2012 at 4:00 PM, Joe Bowser <bows...@gmail.com> wrote:
>>
>>> Tagged Android. It's ready to go!
>>>
>>> On Wed, Oct 24, 2012 at 12:57 PM, Shazron <shaz...@gmail.com> wrote:
>>> > I'll update the iOS bits right now.
>>> >
>>> > On Wed, Oct 24, 2012 at 11:57 AM, Filip Maj <f...@adobe.com> wrote:
>>> >> JS. Mobile spec and hello world app is tagged.
>>> >>
>>> >> Gogo!
>>> >>
>>> >> On 10/19/12 1:41 AM, "Leutwyler, Markus" 
>>> >> <markus.leutwy...@hp.com>
>>> wrote:
>>> >>
>>> >>>+1
>>> >>>
>>> >>>Let me know if you need any help
>>> >>>
>>> >>>Markus
>>> >>>
>>> >>>-----Original Message-----
>>> >>>From: Filip Maj [mailto:f...@adobe.com]
>>> >>>Sent: Donnerstag, 18. Oktober 2012 20:47
>>> >>>To: callback-...@incubator.apache.org
>>> >>>Subject: 2.2.0rc2 Monday?
>>> >>>
>>> >>>That cool? Would be good to get a cordova-js friendly version of 
>>> >>>webos out there.
>>> >>>
>>> >>
>>>
>>
>>

Reply via email to