[ 
https://issues.apache.org/jira/browse/CB-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Grebnov resolved CB-1758.
--------------------------------

    Resolution: Fixed
      Assignee: Marcel Kinard  (was: Sergey Grebnov)

Reviewed the code, the comments (potential license issue) seem to be absolute 
and not informative so I removed them. Changes are part of pr below
https://github.com/purplecabbage/incubator-cordova-wp7/pull/23
                
> license question with wp7 Notification.cs
> -----------------------------------------
>
>                 Key: CB-1758
>                 URL: https://issues.apache.org/jira/browse/CB-1758
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: WP7
>    Affects Versions: Master
>            Reporter: Marcel Kinard
>            Assignee: Marcel Kinard
>             Fix For: 2.2.0
>
>
> Sergey, could you also do a quick check of the following? The last thing I 
> found: in 
> incubator-cordova-wp7/templates/standalone/cordovalib/Commands/Notification.cs
>  at line 54 it references a URL to examples of an alarm class. I'm wondering 
> if there is any code reuse that doesn't obey the origin license. 
> But I don't see any use of alarms or reminders in this cordova source, just 
> alerts and ok dialogs. So if there is no code reuse then just go ahead and 
> close this issue as invalid. I just wanted to get an extra set of eyes on 
> this. Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to