The only problem I have with these changes is that we don't have solid tests against this. Our jUnit tests are in a semi-broken state at the moment. We should probably spend the next release going through our Java API and deciding what to support, and what we can toss by the wayside.
That being said, this should be supported Java API, since it's an extension of the inherited method. I'm OK with this in this release, but we need to get tests in place for this stuff again. Joe On Thu, Nov 1, 2012 at 7:38 AM, Simon MacDonald <[email protected]> wrote: > Okay, I really hope nobody minds but I just bumped the tag up to my commit. > Minor, minor change. I don't expect any issues to pop up from it and I've > tested it on 2.2, 2.3, 4.0 and 4.1. > > https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=d9db845b435d7b614e20ed5a3065be124a5842f5 > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Thu, Nov 1, 2012 at 10:29 AM, Simon MacDonald > <[email protected]>wrote: > >> No, this is purely a Java code change. >> >> Simon Mac Donald >> http://hi.im/simonmacdonald >> >> >> On Thu, Nov 1, 2012 at 10:18 AM, Jesse MacFadyen >> <[email protected]>wrote: >> >>> Will Cordova-js need to be re-tagged? >>> >>> Cheers, >>> Jesse >>> >>> >>> On 2012-11-01, at 7:11 AM, Simon MacDonald <[email protected]> >>> wrote: >>> >>> > Guys, is it too late to get one more bug fix in on Android? CB-1795 was >>> > raised over night and it shows a regression from 2.1.0 where native >>> options >>> > menus are concerned on Android. There is a fairly simple work around >>> where >>> > you override onPrepareOptionsMenu but I do so hate to regress. >>> > >>> > I'm going to check the fix in shortly once I can do a bit more testing. >>> > Basically I change return false to return true. >>> > >>> > Simon Mac Donald >>> > http://hi.im/simonmacdonald >>> > >>> > >>> > On Thu, Nov 1, 2012 at 9:30 AM, Jesse MacFadyen < >>> [email protected]>wrote: >>> > >>> >> Wait on docs until I finish some windows8 stuff, please. >>> >> >>> >> Cheers, >>> >> Jesse >>> >> >>> >> Sent from my iPhone5 >>> >> >>> >> On 2012-11-01, at 6:22 AM, Marcel Kinard <[email protected]> wrote: >>> >> >>> >>> Almost there! Looks like we are missing only tizen and docs. >>> >>> >>> >>> Tim, looks like you updated www/ for bb, so CB-1774 should be closed? >>> >>> >>> >>> -- Marcel Kinard >>> >>> >>> >>> On 10/31/2012 1:36 PM, Michael Brooks wrote: >>> >>>> Okay guys, >>> >>>> >>> >>>> I've went ahead and created the JIRA issue (CB-1760 [1]) to track the >>> >> 2.2.0 >>> >>>> release process. >>> >>>> >>> >>>> I've also went ahead and tagged cordova-js and the hello-world app. >>> >>>> >>> >>>> Happy tagging! >>> >>>> Michael >>> >>>> >>> >>>> [1] https://issues.apache.org/jira/browse/CB-1760 >>> >>>> >>> >>>> On Wed, Oct 31, 2012 at 10:02 AM, Marcel Kinard <[email protected]> >>> >> wrote: >>> >>>> >>> >>>>> Today is the day to start tagging 2.2.0, right? >>> >>>>> >>> >>>>> Who is going to start it by tagging the js? >>> >>>>> >>> >>>>> -- Marcel Kinard >>> >>>>> >>> >>>>> >>> >>>>> On 10/30/2012 10:07 PM, Andrew Grieve wrote: >>> >>>>> >>> >>>>>> There's nothing outstanding that I'm aware of for iOS / Android. >>> This >>> >>>>>> release is going to be solid! >>> >>>>>> >>> >>>>>> >>> >>>>>> On Tue, Oct 30, 2012 at 7:42 PM, Shazron <[email protected]> >>> wrote: >>> >>>>>> >>> >>>>>> iOS issues all resolved or punted to 2.3.0. >>> >>>>>>> Can the js be tagged? >>> >>>>>>> >>> >>>>>>> On Tue, Oct 30, 2012 at 1:25 PM, Joe Bowser <[email protected]> >>> >> wrote: >>> >>>>>>> >>> >>>>>>>> Hey >>> >>>>>>>> >>> >>>>>>>> So what are we waiting on for the 2.2.0 release? When should we >>> >>>>>>>> expect the JS to be tagged so we can start tagging? >>> >>>>>>>> >>> >>>>>>>> Joe >>> >> >>> >> >>
