On Fri, Nov 2, 2012 at 6:20 PM, Shazron <shaz...@gmail.com> wrote: > Ok I found out its actually in two locations, it's in the > CordovaLibAppTests/www folder as well as the bin/template. > > Yeah having one location would be best -- we did have it not having the > version before though, with copying/updates based on the Makefile. > > I'm thinking we only update: > CordovaLib/cordova.ios.js with the latest from cordova-js > > I think we could do this without the explicit step.
> Then for a release, run a script/Makefile target to update: > 1. CordovaLibAppTests/www/cordova.ios.js > For this, we can add a copy step to the build phases to copy the file in from CordovaLib on each build > 2. bin/templates/project/www with the versioned .js > For this, we can have the create script just grab the .js file from CordovaLib instead of from the templates directory. > > On Fri, Nov 2, 2012 at 2:49 PM, Andrew Grieve <agri...@chromium.org> > wrote: > > > It actually does bother me a little bit too, to have the file name have a > > version in it when we're developing. > > > > I don't really care where we put the file so long as there is only one > copy > > of it and not multiple. > > > > > > On Wed, Oct 31, 2012 at 4:22 PM, Shazron <shaz...@gmail.com> wrote: > > > > > On iOS, the cordova.js used to (inertia really because of the legacy > > > location) be in the CordovaLib folder, and also the template. Since it > > > was redundant, we only put it in the default template in > > > bin/templates/project now. > > > > > > Even this is not ideal with respect to people upgrading and using it > > > as an embedded WebView -- to grab the new .js they have to create a > > > new project (or spelunk into the bin/templates folder). Ideally it > > > should be put back also into CordovaLib because the .js is tightly > > > coupled to a specific CordovaLib library and version, and for easy > > > discovery. Don't know what the ideal situation can be here. > > > > > > On Tue, Oct 30, 2012 at 5:34 PM, Kevin Hawkins < > khawk...@salesforce.com> > > > wrote: > > > > Hi all, > > > > > > > > Apologies if/that I've missed this discussion previously. I'm not > > clear > > > on why the cordova.js file name changes in the iOS repo, particularly > > given > > > the fact that great lengths seem to have been taken everywhere to be > > > agnostic about what the originating name is, opting to dynamically > update > > > the destination name in build scripts, template generation, etc.? > > > > > > > > Changing the originating file name with each new iteration/revision > of > > > Cordova makes it hard to follow its history on GitHub (though it's easy > > > enough locally with git log and --follow), and just generally seems > > > unnecessary. > > > > > > > > Thanks, > > > > Kevin > > > > > > > > > >
