Fair enough. Ill slowly chip away at it.. Tomorrow. :) On 1/7/13 3:41 PM, "Brian LeRoux" <[email protected]> wrote:
>One other thought---when we do move between versions we should be >going from /dist not from the scm. > >On Mon, Jan 7, 2013 at 3:40 PM, Brian LeRoux <[email protected]> wrote: >> As so long as this is abstracted into a discreet module so we can >> remove later I'm cool w/ it for dev purposes. Git is great for >> revision control but way overboard for transferring tarballs over >> http. When we eventually package into a stand alone binary executable >> (the goal) we do not want to have to bundle Git with it for that >> purpose. The audience for Cordova likely has Git so for now its no big >> deal but the audience for downstream distributions are web developers >> ---nuff said. >> >> >> On Mon, Jan 7, 2013 at 2:28 PM, Filip Maj <[email protected]> wrote: >>> Bringing this to the list's attention. Should we or should we not have >>>git >>> as a dependency for the cli tools? >>> >>> I implemented it with git during the 'first-pass' implementation. >>>Removed >>> it at Brian's request. Instead used github's convenient tag zipball >>>url to >>> get specific tags downloaded onto a client machine. >>> >>> Problem: the mirrors are wonky. First the blackberry mirror was down >>>about >>> a month due to us changing the name during the TLP move. Now the >>>Android >>> mirror is out of date by about a month or who knows what reason. >>> >>> As such, to avoid this problem and actually have the cli tools >>>functional, >>> I decided to go back to using git. Don't think the dependency is a huge >>> issue. This way, I can use the source repo (which is up a lot more >>>often >>> than the mirrors, and can actually use it), as well as, once we tackle >>> moving between cordova versions for client apps, we will need to >>>quickly >>> switch between tags anyways, which seems like git is a good use case >>>for. >>> >>> Thoughts? >>> >>> In the mean time I will stop working on this issue. However, please >>>note >>> that the CLI tools have not been working for about a month due to the >>> mirror issues I describe above. >>> >>> On 1/7/13 12:44 PM, "Brian LeRoux (JIRA)" <[email protected]> wrote: >>> >>>> >>>> [ >>>>https://issues.apache.org/jira/browse/CB-2164?page=com.atlassian.jira.p >>>>lug >>>>in.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546245#com >>>>men >>>>t-13546245 ] >>>> >>>>Brian LeRoux commented on CB-2164: >>>>---------------------------------- >>>> >>>>Eh Fil, can we discuss on list? I really feel this is the wrong >>>>approach. >>>> >>>>> Revert CLI tools to using git >>>>> ----------------------------- >>>>> >>>>> Key: CB-2164 >>>>> URL: https://issues.apache.org/jira/browse/CB-2164 >>>>> Project: Apache Cordova >>>>> Issue Type: Bug >>>>> Components: CLI >>>>> Affects Versions: 2.3.0 >>>>> Reporter: Filip Maj >>>>> Assignee: Filip Maj >>>>> Fix For: 2.4.0 >>>>> >>>>> >>>>> There are too many issues with removing git as a dependency. >>>>> First, with future support coming for moving between different >>>>>versions, we will likely need to download and extract multiple >>>>>versions >>>>>of the git repos. >>>>> Second, removing the git dependency and going with just tag downloads >>>>>from github is difficult at this time as the github mirrors are >>>>>inconsistent and keep getting backed up. >>>>> One thing that is stable is the canonical source repo. >>>>> For this issue, remove downloading and extracting tag zipballs. >>>>>Instead, clone the source and checkout the needed tags as necessary. >>>> >>>>-- >>>>This message is automatically generated by JIRA. >>>>If you think it was sent incorrectly, please contact your JIRA >>>>administrators >>>>For more information on JIRA, see: >>>>http://www.atlassian.com/software/jira >>>
