Agree with both of you. Also of note is the ripple effect of adding a feature to one platform, see the slice() discussion for an example. Any new feature should be explored and discussed further than just ios/android.
Cheers, Jesse Sent from my iPhone5 On 2013-01-21, at 10:50 AM, Brian LeRoux <b...@brian.io> wrote: Agree, but this should be just the regular flow rather than a formal check in. Anything big should be in a branch and ideally ppl should socialize branches on the list before the merge. On Mon, Jan 21, 2013 at 12:41 PM, Joe Bowser <bows...@gmail.com> wrote: > Recently we've been noticing that there's been a lot of new features > going into Cordova this release, especially in Android. Now, I know > that I've been guilty of this in the past, which is partly why I'm > saying this now. > > I think that we need to talk about features and make sure they work > before we push them into the master repository. We can't add new > methods that break how Cordova works for our older users without > having a really good reason for it. We have time to actually review > things before they arrive in the master branch, and it's trickier for > us to pull a feature out of master once it's in there, especially when > people commit to the branch after. That's why I think we should have > a review process in place. > > What are people's thoughts on this? > > Joe
