The second change is a very localized bugfix: https://issues.apache.org/jira/browse/CB-2158
All this does is make a broken API work and doesn't leach out into any other areas of BlackBerry. I have tested these changes and the worst case is that we end up with an API broken in another way ;) On Wed, Feb 27, 2013 at 4:36 AM, Andrew Grieve <agri...@chromium.org> wrote: > On Wed, Feb 27, 2013 at 12:53 AM, Anis KADRI <anis.ka...@gmail.com> wrote: > > > I'd like to add bada specific code as well. No impact on any other > > platforms. > > > > On Tuesday, February 26, 2013, Shazron wrote: > > > > > Seems fine to me since it's all BB stuff > > > > > > > > > On Tue, Feb 26, 2013 at 8:37 PM, Gord Tanner <gtan...@gmail.com > > <javascript:;>> > > > wrote: > > > > > > > I would like to add a couple changes into the cordova.blackberry.js > for > > > > 2.5. > > > > > > > > - > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commitdiff;h=03a4b305393735717b5775390695036fa6e43fcc > > > > - > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commitdiff;h=7cb3604b21ce77c442ce469ae7de85f8ccb4b818 > > > > This second one seems not small, and not a regression fix. Why not just > wait for 2.6? > > > > > > > > > > > > Is everyone ok if I put these in and retag? > > > > > > > > > >
