Mapes let's sit down on Monday and merge this stuff in, make sure we've got tests rolling, and release it!
On 4/11/13 2:45 AM, "Michael Wolf" <[email protected]> wrote: >OK hit me up directly when its updated I can help make the some of the >initial tests to review w/ you. Id really like to see this get into 2.7 >so happy to help see this happen. > >mw > >On 4/10/13 5:15 PM, "Benn Mapes" <[email protected]> wrote: > >>Oops, just realized that the wp8_parser didn't get updated with the >>latest >>push to those branches. >>It should look like the wp7_parser since they are virtually identical. >>I'll >>fix that tonight and clean it up a bit. >> >>~Benn >> >> >>On Wed, Apr 10, 2013 at 2:08 PM, Benn Mapes <[email protected]> wrote: >> >>> As for the test .... I'll try and get to those hopefully before 2.7.0, >>> maybe you can help me out a bit on those ones. >>> I've been working mostly on the scripting for windows and now for >>>android. >>> >>> >>> On Wed, Apr 10, 2013 at 2:06 PM, Benn Mapes <[email protected]> >>>wrote: >>> >>>> For the .csproj file you can just use >>>> <Content Include="www\**" /> >>>> to include all the files in the www folder. I used to have it adding >>>>each >>>> file individually like >>>> <Content Include="www\file\name.x" /> >>>> but using the wildcard works the same way. >>>> >>>> >>>> On Wed, Apr 10, 2013 at 2:01 PM, Michael Wolf >>>><[email protected]>wrote: >>>> >>>>> Looks like your lacking tests in both the metadata as well as places >>>>>like >>>>> platform >>>>> ( >>>>> >>>>>https://github.com/bennmapes/cordova-cli/blob/windows2/spec/platform.s >>>>>p >>>>>ec. >>>>> >>>>>js<https://github.com/bennmapes/cordova-cli/blob/windows2/spec/platfor >>>>>m >>>>>.spec.js>) >>>>> etc >>>>> >>>>> Happy to give your changes a whirl, but are you planning on >>>>>contributing >>>>> tests? Particularly in that >>>>> >>>>> >>>>>https://github.com/bennmapes/cordova-cli/blob/windows2/src/metadata/wp >>>>>8 >>>>>_par >>>>> >>>>>ser.js<https://github.com/bennmapes/cordova-cli/blob/windows2/src/meta >>>>>d >>>>>ata/wp8_parser.js>needs to do the fun stuff of updating the proj file >>>>>, which would >>>>> easily go screwy. >>>>> >>>>> mw >>>>> >>>>> >>>>> On 4/10/13 4:46 PM, "Benn Mapes" <[email protected]> wrote: >>>>> >>>>> >I well the pull request is still there and I have 2 branches with >>>>>the >>>>> >windows phone support, the old one: >>>>> > >>>>> >https://github.com/bennmapes/cordova-cli/tree/windows >>>>> > >>>>> >And the updated one with the latest cli changes (2.6.0) >>>>> > >>>>> >https://github.com/bennmapes/cordova-cli/tree/windows2 >>>>> > >>>>> >The only thing that needs to happen is for people to start using it >>>>>and >>>>> >submitting issues. If we're not going to pull out the the platforms >>>>>in >>>>> >/lib >>>>> >and add them dynamically then I see no reason to hold off pulling >>>>>this >>>>> in. >>>>> > >>>>> > >>>>> >On Wed, Apr 10, 2013 at 12:08 PM, Michael Wolf >>>>> ><[email protected]>wrote: >>>>> > >>>>> >> Benn: >>>>> >> >>>>> >> Looking for any help here ? Really looking for the wp8 cli to >>>>>come in >>>>> >>so >>>>> >> we can drop our own sad little wp8 scripts. >>>>> >> >>>>> >> Hit me up directly if your looking for a hand/eye. >>>>> >> >>>>> >> mw >>>>> >> >>>>> >> On 3/22/13 6:06 PM, "Filip Maj" <[email protected]> wrote: >>>>> >> >>>>> >> >Sweet. Don't forget tests :) >>>>> >> > >>>>> >> >On 3/22/13 3:02 PM, "Benn Mapes" <[email protected]> wrote: >>>>> >> > >>>>> >> >>I have added support for wp7 + wp8 on this branch and made a >>>>>pull >>>>> >>request >>>>> >> >>to cordova-cli but I think it would be best to hold off merging >>>>>it >>>>> >> >>in until we decide what to do with the lib folder (i.e >>>>>dynamically >>>>> >>load >>>>> >> >>platforms when we call `cordova platform add foo` for the first >>>>> time). >>>>> >> >> >>>>> >> >>https://github.com/bennmapes/cordova-cli/tree/windows >>>>> >> >> >>>>> >> >>Just woking on the update_config function in the wp*_parser so >>>>>that >>>>> >>you >>>>> >> >>can >>>>> >> >>change the name/id from the config.xml >>>>> >> >> >>>>> >> >> >>>>> >> >>On Fri, Mar 22, 2013 at 10:58 AM, Brian LeRoux <[email protected]> >>>>>wrote: >>>>> >> >> >>>>> >> >>> None have support currently in the CLI tools. >>>>> >> >>> >>>>> >> >>> - Herm is pursuing platform level scripts so support for FxOS >>>>>can >>>>> >> >>>happen. >>>>> >> >>> - Mapes is doing the same in Windows land. >>>>> >> >>> >>>>> >> >>> Both cases we could use some help. If any on this list care >>>>>about >>>>> >> >>> those platforms and would like to pitch in this is the thread >>>>>to >>>>> >> >>> introduce yourself. >>>>> >> >>> >>>>> >> > >>>>> >> >>>>> >> >>>>> >>>>> >>>> >>> >
