Great work Benn. Braden echoed exactly my thoughts.

On Tue, Jun 4, 2013 at 7:47 AM, Braden Shepherdson <bra...@chromium.org>wrote:

> I've wanted to do this since I first opened the files in CLI. It's much
> better these days than it was, at least. Glad to see it's still moving.
>
> Braden
>
>
> On Mon, Jun 3, 2013 at 8:42 PM, Filip Maj <f...@adobe.com> wrote:
>
> > Works well for me on my machine, +1
> >
> > On 6/3/13 5:40 PM, "Benn Mapes" <benn.ma...@gmail.com> wrote:
> >
> > >Working with the cordova-cli code I have noticed that there are lots of
> > >repetitive platform-specific references in many of the files. I have
> tried
> > >to consolidate all of these into the platforms.js file at the root of
> the
> > >project. I push up this branch to apache:
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=shortlog;h=ref
> > >s/heads/platform-reorg
> > >
> > >As far as I know, all the test pass on windows and mac, I haven't
> > >physically tested every part yet to make sure this didn't break anything
> > >but I believe not.
> > >
> > >This change is working towards consolidating all platforms so that it's
> > >very easy to add and remove them if needed. The ultimate goal for
> adding a
> > >new platform should be to just add it to platforms.js and create a
> parser
> > >+
> > >tests for it.
> > >
> > >Please let me know what you think, if everyone is in agreeance hen I
> will
> > >add this to the master2 branch.
> > >
> > >~Benn
> >
> >
>

Reply via email to